Skip to content

Adjust quickstart to data validators #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fa9r merged 3 commits into from
Jul 26, 2022
Merged

Adjust quickstart to data validators #797

fa9r merged 3 commits into from
Jul 26, 2022

Conversation

@fa9r
Copy link
Contributor

@fa9r fa9r commented Jul 25, 2022 •
edited
Loading

Describe changes

I fixed the quickstart by correctly using the new data validator stack components.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@review-notebook-app
Copy link

review-notebook-app bot commented Jul 25, 2022

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Jul 25, 2022
@fa9r fa9r changed the title Adjust examples to data validators Adjust quickstart to data validators Jul 25, 2022
@fa9r fa9r requested review from htahir1 and stefannica July 25, 2022 13:48
@fa9r
Copy link
Contributor Author

fa9r commented Jul 25, 2022

not ready for review yet, just pre-tagging ;)

@fa9r fa9r marked this pull request as ready for review July 26, 2022 07:57
@fa9r fa9r merged commit 7c11bb0 into develop Jul 26, 2022
@fa9r fa9r deleted the bugfix/ENG-1088-adjust-examples-to-data-validators branch July 26, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefannica stefannica stefannica approved these changes

@htahir1 htahir1 Awaiting requested review from htahir1

Assignees

No one assigned

Labels

bug Something isn't working internal To filter out internal PRs and issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fa9r @stefannica