Skip to content

Raise zenml exception when cyclic graph is detected #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schustmi merged 2 commits into from
Aug 29, 2022
Merged

Raise zenml exception when cyclic graph is detected #866

schustmi merged 2 commits into from
Aug 29, 2022

Conversation

@schustmi
Copy link
Contributor

@schustmi schustmi commented Aug 29, 2022 •
edited
Loading

Describe changes

I implemented/fixed _ to achieve _.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Aug 29, 2022
@schustmi schustmi requested a review from strickvl August 29, 2022 08:52
htahir1
htahir1 reviewed Aug 29, 2022
View reviewed changes
@schustmi schustmi merged commit a30b9ff into develop Aug 29, 2022
@schustmi schustmi deleted the feature/update-cyclic-dag-error branch August 29, 2022 14:04
stefannica pushed a commit that referenced this pull request Sep 14, 2022
@schustmi @stefannica
Raise zenml exception when cyclic graph is detected (#866)
875c96e 
* Raise zenml exception when cyclic graph is detected

* Add missing exception in docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@htahir1 htahir1 htahir1 approved these changes

@strickvl strickvl Awaiting requested review from strickvl

+1 more reviewer

@fa9r fa9r fa9r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request internal To filter out internal PRs and issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@schustmi @htahir1 @fa9r