Fix #805 don't blur() the trigger after a clipboard action
#807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's pointless to set `focus()` on the trigger first, if in the next step you're just going to `blur()` the active element anyway.
Since it's now not `blur()`ing anymore
obetomuniz
reviewed
Apr 29, 2022
obetomuniz
requested changes
Apr 29, 2022
obetomuniz
approved these changes
May 3, 2022
There was a problem hiding this comment.
Awesome! Thanks a lot for this contribution, @patrickhlauke. In the next few days, we'll be releasing this PR in a brand new version 👏👏👏
|
wonderful! thank you. |
helderberto
approved these changes
May 4, 2022
This was referenced May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
This PR reintroduces the behavior that used to be in clipboard.js following #419 but that has since been reverted for some reason. As such, after a clipboard action, focus will remain/be on the trigger element, rather than the body. If applications rely on the focus to be gone/removed from the trigger button, they'll need to adapt to this.
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)I didn't target v2.x branch because it looks wildly out of date.
Other information:
I'm not too hot on writing tests, so rather than just removing the check to see if focus is now on the body, it should probably explicitly check that focus remained on the trigger. However, not quite sure how to do that - my knowledge of test harnesses etc is pretty basic.
Closes #805