Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

tsrm_ls compile error with vc6/php5.2 #24

Closed
stevenbalthazor opened this Issue · 1 comment

2 participants

@stevenbalthazor

When I compile using vc6 on windows against the latest zenovich/runkit on php5.2.X, I get the following error:

runkit_functions.c(263) : error C2143: syntax error : missing ';' before 'type'
runkit_functions.c(269) : error C2065: 'tsrm_ls' : undeclared identifier

I found a reference here: http://flylib.com/books/en/2.565.1.14/1/ (bottom of that page) which indicated that the tsrm declarations might need to go before anything else. I moved the tsrm_ls definition up a few lines in the same method and it appeared to solve the compilation problem. I don't know enough to know if that makes any difference in the overall functionality

OLD

    if (!hash_key->nKeyLength) {
        /* Nonsense, skip it */
        return ZEND_HASH_APPLY_REMOVE;
    }

#if (RUNKIT_UNDER53)
    void ***tsrm_ls = va_arg(args, void***); /* NULL when !defined(ZTS) */
#endif

NEW

#if (RUNKIT_UNDER53)
    void ***tsrm_ls = va_arg(args, void***); /* NULL when !defined(ZTS) */
#endif

    if (!hash_key->nKeyLength) {
        /* Nonsense, skip it */
        return ZEND_HASH_APPLY_REMOVE;
    }

Thanks for the great functionality.

Regards,
Steven Balthazor

@zenovich
Owner

The patch 3b227ec should fix the issue. Please, check it again.

@zenovich zenovich closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.