From 2777af676f23ba731bb17e2c07544dd5a288b409 Mon Sep 17 00:00:00 2001
From: acrylian <wartgart@gmx.net>
Date: Fri, 15 Dec 2023 18:53:19 +0100
Subject: [PATCH] =?UTF-8?q?Fix=20issue=20with=20new=20sub=20albums=20not?=
 =?UTF-8?q?=20saving=20data=20caused=20by=20an=20extra=20check=20added=20f?=
 =?UTF-8?q?or=20forgotten=20reasons=E2=80=A6=20#1396?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 zp-core/classes/class-albumbase.php | 50 +++++++++++++----------------
 1 file changed, 23 insertions(+), 27 deletions(-)

diff --git a/zp-core/classes/class-albumbase.php b/zp-core/classes/class-albumbase.php
index 22c93a894..efd5036e3 100644
--- a/zp-core/classes/class-albumbase.php
+++ b/zp-core/classes/class-albumbase.php
@@ -143,19 +143,17 @@ function getFolder() {
 	 * @return object|null
 	 */
 	function getParent() {
-		if ($this->getParentID()) {
-			if (is_null($this->parentalbum)) {
-				$slashpos = strrpos($this->name, "/");
-				if ($slashpos) {
-					$parent = substr($this->name, 0, $slashpos);
-					$parentalbum = AlbumBase::newAlbum($parent, true, true);
-					if ($parentalbum->exists) {
-						return $this->parentalbum = $parentalbum;
-					}
+		if (is_null($this->parentalbum)) {
+			$slashpos = strrpos($this->name, "/");
+			if ($slashpos) {
+				$parent = substr($this->name, 0, $slashpos);
+				$parentalbum = AlbumBase::newAlbum($parent, true, true);
+				if ($parentalbum->exists) {
+					return $this->parentalbum = $parentalbum;
 				}
-			} else if ($this->parentalbum->exists) {
-				return $this->parentalbum;
 			}
+		} else if ($this->parentalbum->exists) {
+			return $this->parentalbum;
 		}
 		return NULL;
 	}
@@ -168,23 +166,21 @@ function getParent() {
 	 * @return array|null
 	 */
 	function getParents() {
-		if ($this->getParentID()) {
-			if (is_null($this->parentalbums)) {
-				$albumarray = getAlbumArray($this->name, false);
-				if (count($albumarray) == 1) {
-					$parent = $this->getParent();
-					$this->urparentalbum = $parent;
-					return $this->parentalbums = array($parent);
-				}
-				$parents = array();
-				$album = $this;
-				while (!is_null($album = $album->getParent())) {
-					array_unshift($parents, $album);
-				}
-				return $this->parentalbums = $parents;
-			} else {
-				return $this->parentalbums;
+		if (is_null($this->parentalbums)) {
+			$albumarray = getAlbumArray($this->name, false);
+			if (count($albumarray) == 1) {
+				$parent = $this->getParent();
+				$this->urparentalbum = $parent;
+				return $this->parentalbums = array($parent);
 			}
+			$parents = array();
+			$album = $this;
+			while (!is_null($album = $album->getParent())) {
+				array_unshift($parents, $album);
+			}
+			return $this->parentalbums = $parents;
+		} else {
+			return $this->parentalbums;
 		}
 		return $this->parentalbums = array();
 	}