Skip to content

Implement and enforce requirements for names of attributes, resolvers, and matchers. #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davemoore- opened this issue Feb 11, 2021 · 2 comments
Closed

Implement and enforce requirements for names of attributes, resolvers, and matchers. #73

davemoore- opened this issue Feb 11, 2021 · 2 comments
Labels
enhancement New feature or request release:1.7.0

Comments

@davemoore-
Copy link
Member

Attributes, resolvers, and matchers should have the same naming requirements as entity type names (see #58) for the same reasons listed in that issue.

This change should be included in the same release as #58 so that users can fix deprecated names in their entity models in one release.

Index names and index field names can be excluded from this validation. Elasticsearch validates those, but only zentity can validate attributes, resolvers, and matchers.
@davemoore- davemoore- added the enhancement New feature or request label Feb 11, 2021
@davemoore- davemoore- mentioned this issue Feb 12, 2021
Closed
12 tasks
@davemoore-
Copy link
Member Author

Opened PR #75

@davemoore- davemoore- mentioned this issue Feb 20, 2021
Closed
@davemoore-
Copy link
Member Author

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request release:1.7.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davemoore-