Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enforce entity name requirements #63


Copy link

@austince austince commented Jan 25, 2021

As per the ES index naming requirements, this PR brings in validation to entity types, based on the ES implementation. This enforces the name requirements on create and update model methods, which is aligned with Elasticsearch's somewhat lenient handling of index names:

DELETE -someindex # returns 404 not found

GET -someindex # returns 404 not found

PUT -someindex  # returns 400 validation error

Closes #58

@austince austince force-pushed the feat-models-enforce-naming-requirements branch 4 times, most recently from ececeb7 to f00a727 Compare January 26, 2021 20:25
Copy link
Contributor Author

Sorry about the repeated pushes, keep committing pieces of our fork 🤦🏼‍♂️ should be final now.

Copy link
Contributor Author

austince commented Feb 2, 2021

Rebasing to fix conflicts..

@austince austince force-pushed the feat-models-enforce-naming-requirements branch from f00a727 to 6c20792 Compare February 2, 2021 23:39
@austince austince force-pushed the feat-models-enforce-naming-requirements branch from 6c20792 to bd68a48 Compare February 2, 2021 23:46
Copy link

@davemoore- davemoore- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@davemoore- davemoore- merged commit d3a3914 into zentity-io:master Feb 3, 2021
@davemoore- davemoore- mentioned this pull request Feb 3, 2021
12 tasks
@austince austince deleted the feat-models-enforce-naming-requirements branch February 3, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Implement and enforce requirements for entity type names
2 participants