New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong group entry in .conf when adding "All domain users" ACL for file-share #1813

Closed
mmram opened this Issue Jul 9, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@mmram

mmram commented Jul 9, 2018

Version 5.1.1
When adding an ACL for a share for the predefined group "All domain users" the entry in /etc/samba/shares.conf is not @"Domain Users" but instead @"All domain users" or whatever the translated name is in the language selected in frontend (e.g. @"Alle Domänen-Benutzer" in german). This leads to a non-working ACL and non-accessible share because of the non-existing translated group.

Everything works fine if I change the .conf-entry to @"Domain Users" afterwards.

Frontend routines should write the non-translated group name to shares.conf here.

@doudz

This comment has been minimized.

Contributor

doudz commented Aug 8, 2018

I just migrate to 5.1 this morning and I have the same problem.
For me it's not translated in french, it's @"All domain users" instead of @"Domain users"
Replacing entries in /etc/samba/shares.conf is a workaround but it's a bit annoying since changes are overwritten by zentyal when zentyal restart the share service

@doudz

This comment has been minimized.

Contributor

doudz commented Aug 8, 2018

I create a PR to fix the problem
#1816

@Neustradamus

This comment has been minimized.

Neustradamus commented Sep 16, 2018

@jacalvo soon?

@Neustradamus

This comment has been minimized.

Neustradamus commented Sep 19, 2018

@jacalvo

This comment has been minimized.

Member

jacalvo commented Sep 20, 2018

thanks for the PR @doudz, but next time please use master as base branch

closing this as fix is commited

@jacalvo jacalvo closed this Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment