Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set default array value on extends #2089

Closed
mruz opened this issue May 1, 2020 · 7 comments · Fixed by #2098
Closed

Can't set default array value on extends #2089

mruz opened this issue May 1, 2020 · 7 comments · Fixed by #2098
Assignees
Labels

Comments

@mruz
Copy link
Contributor

mruz commented May 1, 2020

Zephir

namespace Ice;

class Test
{
    protected rules = [] { set, get };
}

PHP

<?php
use Ice\Test;

class Users extends Test
{
    protected $rules = [
        'username' => 'required',
    ];
}

$user = new Users();
var_dump($user->getRules());

$user->setRules([
        'username' => 'required'
]);

var_dump($user->getRules());

Output:

array(0) {
}
array(1) {
  ["username"]=>
  string(8) "required"
}

Expected to get it after an object is initialized. Looks like #537 returned.

PHP 7.4.5 (cli) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies

@sergeyklay
Copy link
Member

@mruz Could you please check previous Zephir version just to clarify we don't break anything in #2078

mruz added a commit to mruz/zephir that referenced this issue May 1, 2020
@mruz
Copy link
Contributor Author

mruz commented May 1, 2020

@sergeyklay seems fine on zephir 0.12.17, I also added a test for it.

@sergeyklay sergeyklay added the bug label May 1, 2020
@sergeyklay
Copy link
Member

@dreamsxin I need your help here. Could you please take a look. Also see #2090

@dreamsxin
Copy link
Contributor

@sergeyklay create_object is later than declare property.

test_properties_protectedproperties_ce->create_object = zephir_init_properties_Test_Properties_ProtectedProperties;

@sergeyklay
Copy link
Member

Fixed in the development branch. Thank you for the bug report!

@mruz
Copy link
Contributor Author

mruz commented May 10, 2020

@sergeyklay thank you!

@sergeyklay
Copy link
Member

You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants