Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated static property add/sub #2038

merged 2 commits into from Jan 2, 2020


Copy link


  • Type: bug fix | new feature | code quality | documentation
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:


Copy link

codecov bot commented Jan 1, 2020

Codecov Report

Merging #2038 into development will increase coverage by 0.08%.
The diff coverage is 0%.

@@                Coverage Diff                @@
##             development    #2038      +/-   ##
+ Coverage          35.35%   35.44%   +0.08%     
+ Complexity          8323     8301      -22     
  Files                564      564              
  Lines              45744    45692      -52     
+ Hits               16175    16195      +20     
+ Misses             29569    29497      -72

let self::someAdd += 1.0;
let self::someSub -= 1.0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreamsxin Could you create a PHPUnit test to prove these methods?

Copy link
Contributor Author

@sergeyklay Check again

@sergeyklay sergeyklay merged commit ea857f2 into zephir-lang:development Jan 2, 2020
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants