Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to redeclare interface methods in the abstract #416

Merged
merged 1 commit into from Jun 12, 2014

Conversation

@christiaan
Copy link
Contributor

@christiaan christiaan commented May 26, 2014

The abstract functions getCommand, getUsage and getDescription are already declared in the CommandInterface which is implemented by the CommandAbstract.

@christiaan
Copy link
Contributor Author

@christiaan christiaan commented May 26, 2014

This is the only thing I ran into while working with Zephir on Debian Squeeze running PHP 5.3.3-7+squeeze19

Awesome work!

phalcon pushed a commit that referenced this pull request Jun 12, 2014
No need to redeclare interface methods in the abstract
@phalcon phalcon merged commit e670854 into zephir-lang:master Jun 12, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@ghost
Copy link

@ghost ghost commented Jun 12, 2014

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants