Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some arithmetical errors #441

Merged
merged 2 commits into from
Jul 18, 2014
Merged

Conversation

rodrigorm
Copy link
Contributor

No description provided.

@@ -86,6 +87,7 @@ public function testBoolSum()
$this->assertTrue($this->class->bool2Sum() == true);
$this->assertTrue($this->class->bool3Sum() == true);
$this->assertTrue($this->class->boolSumSimple() == true);
$this->assertTrue($this->class->boolSumExpression() == true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove comparison.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I remove all the comparisons?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

phalcon pushed a commit that referenced this pull request Jul 18, 2014
Fix some arithmetical errors
@phalcon phalcon merged commit dbd1d46 into zephir-lang:master Jul 18, 2014
@phalcon
Copy link

phalcon commented Jul 18, 2014

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants