Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some arithmetical errors #441

Merged
merged 2 commits into from Jul 18, 2014
Merged

Conversation

@rodrigorm
Copy link
Contributor

@rodrigorm rodrigorm commented Jul 11, 2014

No description provided.

@@ -86,6 +87,7 @@ public function testBoolSum()
$this->assertTrue($this->class->bool2Sum() == true);
$this->assertTrue($this->class->bool3Sum() == true);
$this->assertTrue($this->class->boolSumSimple() == true);
$this->assertTrue($this->class->boolSumExpression() == true);

This comment has been minimized.

@nkt

nkt Jul 12, 2014
Contributor

Please remove comparison.

This comment has been minimized.

@rodrigorm

rodrigorm Jul 12, 2014
Author Contributor

Can I remove all the comparisons?

This comment has been minimized.

@nkt

nkt Jul 13, 2014
Contributor

yep

@@ -41,6 +41,7 @@ public function testDoubleSum()
$this->assertTrue($this->class->double2Sum() == 3.0);
$this->assertTrue($this->class->doubleSumSimple() == 3.0);
$this->assertTrue($this->class->doubleSum2Simple() == 3.0);
$this->assertTrue($this->class->doubleSumExpression() == 2.0);

This comment has been minimized.

@nkt

nkt Jul 12, 2014
Contributor

Please use assertSame

This comment has been minimized.

@rodrigorm

rodrigorm Jul 12, 2014
Author Contributor

Can I change all asserts?

This comment has been minimized.

@nkt

nkt Jul 13, 2014
Contributor

yes, you are.

phalcon pushed a commit that referenced this pull request Jul 18, 2014
Fix some arithmetical errors
@phalcon phalcon merged commit dbd1d46 into zephir-lang:master Jul 18, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@ghost
Copy link

@ghost ghost commented Jul 18, 2014

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants