Update pinMode behavior #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable internal pull-up/down based on user code * Test for OUTPUT keyword Signed-off-by: Mike Szczys <mike@golioth.io>
* Explain where to look for path setting in sample code folders * Explain where to find file for the WCharacter.h workaround Signed-off-by: Mike Szczys <mike@golioth.io>
Outputs will be driven so a pull-down is not needed. Signed-off-by: Mike Szczys <mike@golioth.io>
DhruvaG2000
approved these changes
Aug 2, 2022
Member
DhruvaG2000
left a comment
DhruvaG2000
left a comment
There was a problem hiding this comment.
PULL_DOWN does seem redundant probably. Thanks for removing
DhruvaG2000
approved these changes
Aug 2, 2022
Member
DhruvaG2000
left a comment
DhruvaG2000
left a comment
There was a problem hiding this comment.
This makes it much clearer, thanks
DhruvaG2000
reviewed
Aug 2, 2022
Member
DhruvaG2000
left a comment
DhruvaG2000
left a comment
There was a problem hiding this comment.
This also offers the user more control. LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates how pull-up and pull-down resistors are handled. It also clarifies path and workarounds in the README.