zephyrCommon: Implement attachInterrupt()/detachInterrupt() #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'm testing with nrf52840 with this patch https://github.com/soburi/zephyr/tree/nrfx_gpio_get_config |
soburi
force-pushed
the
attachInterrupt
branch
from
85a4871 to
d2c2059
Compare
soburi
force-pushed
the
attachInterrupt
branch
from
d2c2059 to
e65b7bf
Compare
soburi
force-pushed
the
attachInterrupt
branch
2 times, most recently
from
c01299f to
98cd47f
Compare
DhruvaG2000
requested changes
Sep 25, 2022
samples/attach_interrupt/prj.conf
Outdated
| @@ -0,0 +1,4 @@ | |||
| CONFIG_GPIO=y | |||
| CONFIG_CPLUSPLUS=y | |||
Member
There was a problem hiding this comment.
The module Kconfig already takes care of CPP and GPIO configs, if ARDUI API is enabled, so this can be dropped from prj.conf
imply CPLUSPLUS
imply GPIO
Member
There was a problem hiding this comment.
@soburi can you take a look at if this is required again please?
Member
Author
There was a problem hiding this comment.
Removed CONFIG_CPLUSPLUS and CONFIG_GPIO.
soburi
force-pushed
the
attachInterrupt
branch
from
98cd47f to
ef0fc41
Compare
DhruvaG2000
requested changes
Sep 25, 2022
cores/arduino/zephyrCommon.cpp
Outdated
| } | ||
| } | ||
|
|
||
| void pinModeImpl(pin_size_t pinNumber, gpio_flags_t pinmode, voidFuncPtr callback, gpio_flags_t intmode) |
Member
There was a problem hiding this comment.
It seems like this PR is doing much more than just Implementing attachInterrupt()/detachInterrupt, and thus in my opinion deserves to have it's own commit that separates the modifications that have been made in the way that pinMode was earlier implemented.
Member
There was a problem hiding this comment.
Also if possible, the commit message should justify the use of new pinMode being better than earlier one and also the addition of GPIO_MODE_MASK instead of directly using each individual GPIO_XX flag as and when required?
Member
Author
There was a problem hiding this comment.
As a result of redesign, I was able to eliminate this.
It's just attachInterrupt/detachInterrupt and their internal implementation.
soburi
force-pushed
the
attachInterrupt
branch
from
ef0fc41 to
3c9c270
Compare
Member
Author
|
Redesign based on #60. |
Member
|
Any reason this is still a draft PR? Please mark as ready if you want it to be reviewed, |
soburi
force-pushed
the
attachInterrupt
branch
from
3c9c270 to
9df6b4c
Compare
The internal data structure named `gpio_port_callback` stores GPIO callback handlers. The `gpio_port_callback` allocate the data per GPIO device. The `gpio_port_callback` has an array of function pointers to store handler. The largest count of the gpio pin count among the GPIO devices that using (which means it exists in the `digital-pin-gpios`) determines the array size. It calculates the data size at compile time. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
Add a sample to demonstrate how to use attachInterrupt Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
soburi
force-pushed
the
attachInterrupt
branch
from
9df6b4c to
793c765
Compare
DhruvaG2000
approved these changes
Nov 19, 2022
Member
DhruvaG2000
left a comment
DhruvaG2000
left a comment
There was a problem hiding this comment.
Tested on my ble sense 33 and I was able to toggle LED by giving interrupts on D2 pin.
Hence,
Tested-by: Dhruva Gole
Thanks for this great feature addition @soburi !
soburi
pushed a commit
to soburi/gsoc-2022-arduino-core
that referenced
this pull request
Aug 23, 2025
Resolves: zephyrproject-rtos#51 There is an IO pin on the NANO that that when turned on, enables most of the sensors on the BLE sense which are on SPI1. The MBED version, enables this pin as part of the main(). Which I am trying to emulate. There is code already in, that if you use at least one of the zephyr device drivers, will eanble this pin. However that does not help when you are using external libraries or the like. So I added details about this pin in our overlay file, in the zephyr,user section. I then added code to main.cpp, that is only included if your are building using an NRFX board. Currently the nano and one of the nicla boards. Could also specically only do this on the NANO, but probably does not matter as, the code tries to find that property and only if it is found, does it turn on the pin. Note: The MBED version turn on this pin with high drive. Which I emulated using the information, mentioned in the zephyr discussion. zephyrproject-rtos/zephyr#78710 In one of my sketches I verified that the pin pads configuration looks the same as mbed setup. With these changes I am able to access most of the sensors. Most of the testing has been done by @mjs513, with some by myself as well.
soburi
pushed a commit
to soburi/gsoc-2022-arduino-core
that referenced
this pull request
Aug 23, 2025
Resolves: zephyrproject-rtos#51 There is an IO pin on the NANO that that when turned on, enables most of the sensors on the BLE sense which are on SPI1. The MBED version, enables this pin as part of the main(). Which I am trying to emulate. There is code already in, that if you use at least one of the zephyr device drivers, will eanble this pin. However that does not help when you are using external libraries or the like. So I added details about this pin in our overlay file, in the zephyr,user section. I then added code to main.cpp, that is only included if your are building using an NRFX board. Currently the nano and one of the nicla boards. Could also specically only do this on the NANO, but probably does not matter as, the code tries to find that property and only if it is found, does it turn on the pin. Note: The MBED version turn on this pin with high drive. Which I emulated using the information, mentioned in the zephyr discussion. zephyrproject-rtos/zephyr#78710 In one of my sketches I verified that the pin pads configuration looks the same as mbed setup. With these changes I am able to access most of the sensors. Most of the testing has been done by @mjs513, with some by myself as well.
soburi
pushed a commit
to soburi/gsoc-2022-arduino-core
that referenced
this pull request
Sep 24, 2025
Resolves: zephyrproject-rtos#51 There is an IO pin on the NANO that that when turned on, enables most of the sensors on the BLE sense which are on SPI1. The MBED version, enables this pin as part of the main(). Which I am trying to emulate. There is code already in, that if you use at least one of the zephyr device drivers, will eanble this pin. However that does not help when you are using external libraries or the like. So I added details about this pin in our overlay file, in the zephyr,user section. I then added code to main.cpp, that is only included if your are building using an NRFX board. Currently the nano and one of the nicla boards. Could also specically only do this on the NANO, but probably does not matter as, the code tries to find that property and only if it is found, does it turn on the pin. Note: The MBED version turn on this pin with high drive. Which I emulated using the information, mentioned in the zephyr discussion. zephyrproject-rtos/zephyr#78710 In one of my sketches I verified that the pin pads configuration looks the same as mbed setup. With these changes I am able to access most of the sensors. Most of the testing has been done by @mjs513, with some by myself as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation depends on CONFIG_GPIO_GET_CONFIG
to keep the GPIO state already configured by pinMode().