Skip to content
Permalink
Browse files

disk: kconfig: Group related symbols and use 'menuconfig' symbol

Put the symbols that depend on DISK_ACCESS_{RAM,FLASH,SDHC} directly
after the symbol they depend on, so that they end up in an implicit
indented menu. That makes it easier to see which symbols are related.

It also indirectly makes all symbols children of DISK_ACCESS. To save a
menu level, turn DISK_ACCESS into a 'menuconfig' symbol and put it in
the top-level menu. Change its prompt from "Enable Disk Interface" to
"Disk Interface", to be consistent with e.g. "Logging".

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
  • Loading branch information...
ulfalizer authored and nashif committed May 15, 2019
1 parent ac4eb32 commit 04ccd40093030bef0f37147d5220e2f17590eb69
Showing with 16 additions and 23 deletions.
  1. +16 −23 subsys/disk/Kconfig
@@ -4,10 +4,8 @@
# SPDX-License-Identifier: Apache-2.0
#

menu "Disk"

config DISK_ACCESS
bool "Enable Disk Interface"
menuconfig DISK_ACCESS
bool "Disk Interface"
help
Enable disk access over a supported media backend like FLASH or RAM

@@ -30,21 +28,6 @@ config DISK_ACCESS_RAM
This option can be used to test the file
system.

config DISK_ACCESS_FLASH
bool "Flash"
select FLASH
help
Flash device is used for the file system.

config DISK_ACCESS_SDHC
bool "SDHC card over SPI"
select SPI
select FLASH
help
File system on a SDHC card accessed over SPI.

endif # DISK_ACCESS

if DISK_ACCESS_RAM

config DISK_RAM_VOLUME_SIZE
@@ -61,6 +44,12 @@ config DISK_RAM_VOLUME_NAME

endif # DISK_ACCESS_RAM

config DISK_ACCESS_FLASH
bool "Flash"
select FLASH
help
Flash device is used for the file system.

if DISK_ACCESS_FLASH

config DISK_FLASH_VOLUME_NAME
@@ -104,14 +93,18 @@ config DISK_VOLUME_SIZE

endif # DISK_ACCESS_FLASH

if DISK_ACCESS_SDHC
config DISK_ACCESS_SDHC
bool "SDHC card over SPI"
select SPI
select FLASH
help
File system on a SDHC card accessed over SPI.

config DISK_SDHC_VOLUME_NAME
string "SDHC Disk mount point or drive name"
default "SDHC"
depends on DISK_ACCESS_SDHC
help
Disk name as per file system naming guidelines.

endif # DISK_ACCESS_SDHC

endmenu
endif # DISK_ACCESS

0 comments on commit 04ccd40

Please sign in to comment.
You can’t perform that action at this time.