Please sign in to comment.
drivers: adxl362: don't disable callbacks
Enabling and disabling the GPIO callbacks is error prone and unnecessary since the trigger data is protected with a mutex, so it has been removed. This resolves the following issues: - The GPIO callbacks are not being re-enabled properly in the error path of the trigger setting function. - The device pointer used in the GPIO callback to retrieve the ADXL362 driver configuration data is the GPIO device not the ADXL362 device, so this cast is invalid and the int_gpio field is garbage. - There are potential timing issues between enabling interrupts and re-enabling the callbacks. Signed-off-by: Brett Witherspoon <email@example.com>
- Loading branch information...
Showing with 3 additions and 14 deletions.