Skip to content

Commit

Permalink
drivers: interrupt_controller: Remove redundant 'default n' properties
Browse files Browse the repository at this point in the history
Bool symbols implicitly default to 'n'.

A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you
want to override a 'default y' on the base definition of the symbol. It
isn't used like that on any of these symbols though, and is
inconsistent.

This will make the auto-generated Kconfig documentation have "No
defaults. Implicitly defaults to n." as well, which is clearer than
'default n if ...'

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
  • Loading branch information
ulfalizer authored and nashif committed Jul 3, 2018
1 parent d20dac8 commit 13cb4cb
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 10 deletions.
5 changes: 0 additions & 5 deletions drivers/interrupt_controller/Kconfig
Expand Up @@ -10,7 +10,6 @@ menu "Interrupt Controllers"

config LOAPIC
bool "LOAPIC"
default n
select IOAPIC
depends on X86
help
Expand All @@ -25,7 +24,6 @@ config LOAPIC_BASE_ADDRESS

config LOAPIC_SPURIOUS_VECTOR
bool "Handle LOAPIC spurious interrupts"
default n
depends on LOAPIC
help
A special situation may occur when a processor raises its task
Expand Down Expand Up @@ -57,7 +55,6 @@ config IOAPIC

config IOAPIC_DEBUG
bool "IO-APIC Debugging"
default n
depends on IOAPIC
help
Enable debugging for IO-APIC driver.
Expand Down Expand Up @@ -85,7 +82,6 @@ config IOAPIC_MASK_RTE

config MVIC
bool "Intel Quark D2000 Interrupt Controller (MVIC)"
default n
depends on X86
select X86_FIXED_IRQ_MAPPING
help
Expand Down Expand Up @@ -127,7 +123,6 @@ config PLIC

config DW_ICTL
bool "Designware Interrupt Controller"
default n
depends on MULTI_LEVEL_INTERRUPTS
help
Designware Interrupt Controller can be used as a 2nd level interrupt
Expand Down
3 changes: 0 additions & 3 deletions drivers/interrupt_controller/Kconfig.multilevel
Expand Up @@ -7,7 +7,6 @@

config MULTI_LEVEL_INTERRUPTS
bool "Multi-level Interrupts"
default n
depends on GEN_SW_ISR_TABLE
help
Multiple levels of interrupts are normally used to increase the
Expand All @@ -26,7 +25,6 @@ config MAX_IRQ_PER_AGGREGATOR

config 2ND_LEVEL_INTERRUPTS
bool "Second-level Interrupts"
default n
depends on MULTI_LEVEL_INTERRUPTS
help
Second level interrupts are used to increase the number of
Expand Down Expand Up @@ -85,7 +83,6 @@ config 2ND_LVL_INTR_03_OFFSET

config 3RD_LEVEL_INTERRUPTS
bool "Third-level Interrupts"
default n
depends on 2ND_LEVEL_INTERRUPTS
help
Third level interrupts are used to increase the number of
Expand Down
1 change: 0 additions & 1 deletion drivers/interrupt_controller/Kconfig.s1000
Expand Up @@ -7,7 +7,6 @@

config CAVS_ICTL
bool "CAVS Interrupt Logic"
default n
depends on MULTI_LEVEL_INTERRUPTS
help
These are 4 in number supporting a max of 32 interrupts each.
Expand Down
1 change: 0 additions & 1 deletion drivers/interrupt_controller/Kconfig.shared_irq
Expand Up @@ -9,7 +9,6 @@
menuconfig SHARED_IRQ
bool
prompt "Shared interrupt driver"
default n
help
Include shared interrupt support in system. Shared interrupt
support is NOT required in most systems. If in doubt answer no.
Expand Down

0 comments on commit 13cb4cb

Please sign in to comment.