Skip to content
Permalink
Browse files

Bluetooth: controller: Remove incorrect comment

Remove comment stating that UNKNOWN_RSP during encryption procedure
is a workaround.
The core spec mandates that connections should not be dropped if
receiving this control packet during encryption procedure.

Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
  • Loading branch information...
joerchan authored and aescolar committed May 14, 2019
1 parent c8708d9 commit 289eab6ad5090d0a94a67d79f3866f50e2770f37
Showing with 0 additions and 12 deletions.
  1. +0 −6 subsys/bluetooth/controller/ll_sw/ctrl.c
  2. +0 −6 subsys/bluetooth/controller/ll_sw/ull_conn.c
@@ -3446,12 +3446,6 @@ static inline bool isr_rx_conn_enc_unexpected(struct connection *conn,
(opcode != PDU_DATA_LLCTRL_TYPE_REJECT_EXT_IND)))) ||
(conn->role &&
((!conn->refresh &&
/* As a workaround to IOP with some old peer controllers that
* respond with Unknown Rsp PDU to our local Slave Initiated
* Feature request during Encryption Setup initiated by the
* peer, we accept this Unknown Rsp PDU during the Encryption
* setup procedure in progress.
*/
(opcode != PDU_DATA_LLCTRL_TYPE_UNKNOWN_RSP) &&
(opcode != PDU_DATA_LLCTRL_TYPE_TERMINATE_IND) &&
(opcode != PDU_DATA_LLCTRL_TYPE_START_ENC_RSP) &&
@@ -3234,12 +3234,6 @@ static inline bool ctrl_is_unexpected(struct ll_conn *conn, u8_t opcode)
(opcode != PDU_DATA_LLCTRL_TYPE_REJECT_EXT_IND)))) ||
(conn->lll.role &&
((!conn->refresh &&
/* As a workaround to IOP with some old peer controllers that
* respond with Unknown Rsp PDU to our local Slave Initiated
* Feature request during Encryption Setup initiated by the
* peer, we accept this Unknown Rsp PDU during the Encryption
* setup procedure in progress.
*/
(opcode != PDU_DATA_LLCTRL_TYPE_UNKNOWN_RSP) &&
(opcode != PDU_DATA_LLCTRL_TYPE_TERMINATE_IND) &&
(opcode != PDU_DATA_LLCTRL_TYPE_START_ENC_RSP) &&

0 comments on commit 289eab6

Please sign in to comment.
You can’t perform that action at this time.