Skip to content
Permalink
Browse files

Bluetooth: controller: split: Fix shell app regression

Fix shell app regression due to stale tmp role implementation
not fully being removed in commit 4c77bf6 ("Bluetooth:
controller: Remove redundant tmp role implementation").

The regression caused ticker indexes outside of allocations to
be accessed causing application faults and memory corruptions.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
  • Loading branch information...
cvinayak authored and nashif committed May 28, 2019
1 parent afdbc20 commit 8de64fcb81dcc23b072a2d7579ef7990feabd3c7
Showing with 0 additions and 34 deletions.
  1. +0 −29 subsys/bluetooth/controller/Kconfig
  2. +0 −5 subsys/bluetooth/controller/ll_sw/lll.h
@@ -685,35 +685,6 @@ config BT_CTLR_PA_LNA_GPIOTE_CHAN
help
Select the nRF5 GPIOTE channel to use for PA/LNA GPIO feature.

if BT_LL_SW_SPLIT
config BT_TMP
bool "Temporary Role"
depends on BT_SHELL
default y
help
Temporary role to manual test ULL/LLL split architecture.

if BT_TMP
config BT_TMP_MAX
int "Temporary Role Max. Instances"
default 3
help
Maximum supported Temporary role instances.

config BT_TMP_TX_SIZE_MAX
int "Temporary Role Max. Tx buffer size"
default 10
help
Temporary role's maximum transmit buffer size in bytes.

config BT_TMP_TX_COUNT_MAX
int "Temporary Role Max. Tx buffers"
default 1
help
Temporary role's maximum transmit buffer count.
endif # BT_TMP
endif # BT_LL_SW_SPLIT

comment "BLE Controller debug configuration"

config BT_CTLR_ASSERT_HANDLER
@@ -30,11 +30,6 @@
enum {
TICKER_ID_LLL_PREEMPT = 0,

#if defined(CONFIG_BT_TMP)
TICKER_ID_TMP_BASE,
TICKER_ID_TMP_LAST = ((TICKER_ID_TMP_BASE) + (CONFIG_BT_TMP_MAX) - 1),
#endif /* CONFIG_BT_TMP */

#if defined(CONFIG_BT_BROADCASTER)
TICKER_ID_ADV_STOP,
TICKER_ID_ADV_BASE,

0 comments on commit 8de64fc

Please sign in to comment.
You can’t perform that action at this time.