Skip to content
Permalink
Branch: master
Commits on Jun 27, 2019
  1. libc: types: Remove wrong definition

    ceolin authored and nashif committed Jun 25, 2019
    types.h was wrongly defining unsigned as signed and following
    undefining it. This definition was not being used anywhere though.
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Commits on May 17, 2019
  1. x86: Make .rodata readonly

    ceolin authored and nashif committed May 16, 2019
    During the conversion of .bin to .o objcopy was not setting the
    section to be readonly causing the .rodata in the final image has
    write permission.
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Commits on May 1, 2019
  1. security: kernel: Fix STACK_POINTER_RANDOM dependency

    ceolin authored and andrewboie committed Apr 30, 2019
    STACK_POINTER_RANDOM depends on a random generator, this can be either a
    non-random generator (used for testing purpose) or a real random
    generator. Make this dependency explicitly in Kconfig to avoid linking
    problems.
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Commits on Apr 28, 2019
  1. sanitycheck: Fix an error in scan_path exception

    ceolin authored and nashif committed Apr 20, 2019
    The function error expects only one parameter. The excpetion handler in
    scan_path was calling this function with multiple parameters instead of
    formatting the string.
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Commits on Apr 18, 2019
  1. arch: all: Remove not used struct _caller_saved

    ceolin authored and andrewboie committed Apr 17, 2019
    The struct _caller_saved is not used. Most architectures put
    automatically the registers onto stack, in others architectures the
    exception code does it.
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  2. arch: all: Remove legacy code

    ceolin authored and andrewboie committed Apr 17, 2019
    The struct _kernel_ach exists only because ARC' s port needed it, in
    all other ports this was defined as an empty struct. Turns out that
    this struct is not required even for ARC anymore, this is a legacy
    code from nanokernel time.
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Commits on Apr 13, 2019
  1. doc: relnotes: add notes about MISRA-C

    ceolin authored and nashif committed Apr 13, 2019
    Update release notes with MISRA-C info.
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Commits on Apr 3, 2019
  1. arch: x86: Remove not used fp struct

    ceolin authored and nashif committed Mar 30, 2019
    The legacy struct s_coopFloatReg was never being used, though it was
    an empty struct (not wasting space), some symbols were being generate
    for it.
    
    Nevertheless, neither C99 nor C11 allow empty structs, so this
    was also a violation to the C standards.
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
    Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Commits on Apr 2, 2019
  1. tests: fp_sharing: Fix build error

    ceolin authored and nashif committed Mar 29, 2019
    k_disable_float is only available in X86 when LAZY_FP_SHARING is
    set. Adding this condition before using this function.
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Commits on Mar 27, 2019
  1. include: i2c: Add U to unsigned constants

    ceolin authored and nashif committed Mar 21, 2019
    Add U to unsigned integer constants to avoid implict cast
    
    MISRA-C rule 10.1
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  2. include: Add missing U for unsigned constants

    ceolin authored and nashif committed Mar 14, 2019
    MISRA-C rule 10.1
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  3. lib: printk: Make if/iterations evaluate boolean operands

    ceolin authored and nashif committed Mar 14, 2019
    MISRA-C rule 14.4
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  4. kernel: Make if/iteration evaluate boolean operands

    ceolin authored and nashif committed Mar 14, 2019
    Controlling expression of if and iteration statements must have a
    boolean type.
    
    MISRA-C rule 14.4
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  5. arch: x86: Add missing U for unsigned constants

    ceolin authored and nashif committed Mar 14, 2019
    Add U for integer constants to avoid an implicit cast.
    
    MISRA-C rule 10.1
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  6. lib: crc16_sw: Add missing U to unsigned constants

    ceolin authored and nashif committed Mar 14, 2019
    Add U to unsigned integer constants to avoid implicit cast.
    
    MISRA-C rule 10.1
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  7. include: Make statements evaluate boolean expressions

    ceolin authored and nashif committed Mar 14, 2019
    MISRA-C requires that if/while statements have essentially a boolean
    operand.
    
    MISRA-C rule 14.4
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  8. spinlock: Change function signature to return bool

    ceolin authored and nashif committed Mar 14, 2019
    Functions z_spin_lock_valid and z_spin_unlock_valid are essentially
    boolean functions, just change their signature to return a bool instead
    of an integer.
    
    MISRA-C rule 10.1
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  9. lib: rb: Make operands have an appropriate essential type

    ceolin authored and nashif committed Mar 14, 2019
    MISRA-C 8.10.2 defines essential operand types and how to handle them
    through rules 10.1 .. 10.5. This commit adds an U to unsigned constants
    to avoid implicit casts and make if/while statements evaluate a boolean
    to avoid other types being casted to boolean.
    
    MISRA-C rules 10.1, 10.2 and 10.3
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  10. arch: Use macro BIT for shift operations

    ceolin authored and nashif committed Feb 26, 2019
    BIT macro uses an unsigned int avoiding implementation-defined behavior
    when shifting signed types.
    
    MISRA-C rule 10.1
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Commits on Mar 26, 2019
  1. include: Add U for unsigned constants

    ceolin authored and nashif committed Mar 12, 2019
    Add U for integer constants to avoid an implicit cast.
    
    MISRA-C rule 10.1
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  2. arch: arm: Use proper essential types in operands

    ceolin authored and nashif committed Mar 11, 2019
    MISRA defines a serie of essential types, boolean, signed/unsigned
    integers, float, ... and operations must respect these  essential types.
    
    MISRA-C rule 10.1
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  3. kernel: Make statements evaluate boolean expressions

    ceolin authored and nashif committed Mar 8, 2019
    MISRA-C requires that the if statement has essentially Boolean type.
    
    MISRA-C rule 14.4
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  4. include: Make statements evaluate boolean expressions

    ceolin authored and nashif committed Mar 8, 2019
    MISRA-C requires that the if statement has essentially Boolean type.
    
    MISRA-C rule 14.4
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  5. kernel: Make _is_thread_prevented_from_running return a bool

    ceolin authored and nashif committed Mar 8, 2019
    This function was returning an essentially boolean value. Just changing
    the signature to return a bool.
    
    MISRA-C rule 14.4
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  6. arch: x86: Use proper essential types in operands

    ceolin authored and nashif committed Mar 11, 2019
    MISRA defines a serie of essential types, boolean, signed/unsigned
    integers, float, ... and operations must respect these essential types.
    
    MISRA-C rule 10.1
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  7. include: Use macro BIT for shift operations

    ceolin authored and nashif committed Mar 8, 2019
    Use a macro BIT when dealing with bit shift operations.
    
    MISRA-C rule 10.1
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  8. kernel: Use macro BIT for shift operations

    ceolin authored and nashif committed Feb 26, 2019
    BIT macro uses an unsigned int avoiding implementation-defiend behavior
    when shifting signed types.
    
    MISRA-C rule 10.1
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  9. arch: Use macro BIT for shift operations

    ceolin authored and nashif committed Feb 26, 2019
    BIT macro uses an unsigned int avoiding implementation-defined behavior
    when shifting signed types.
    
    MISRA-C rule 10.1
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  10. drivers: counter: stm32: Fix possible overflow

    ceolin authored and galak committed Mar 21, 2019
    Cast ts to u32_t could cause an overflow in that multiplication, since
    time_t is 8 bytes it is not necessary to cast the multiplication's
    result too.
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Commits on Mar 24, 2019
  1. tests: mbox: Check k_mbox_get return

    ceolin authored and nashif committed Mar 23, 2019
    Coverity was complaining that this function was not being checked only
    in a specific case.
    
    Coverity CID: 183066
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Commits on Mar 23, 2019
  1. lib: posix: fs: Fix access invalid memory

    ceolin authored and galak committed Mar 22, 2019
    fs_dirent.name is MAX_FILE_NAME + 1 bytes long, not PATH_MAX. Just
    fixing it to avoid access invalid memory.
    
    Coverity CID: 186037
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  2. samples: 96_argonkey: sensors: Check function return

    ceolin authored and galak committed Mar 22, 2019
    Checking the return of sensor_trigger_set and if it fails log the
    problem and exits.
    
    Coverity CID: 186196
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
  3. samples: ipc: openamp: Avoid dead code

    ceolin authored and galak committed Mar 22, 2019
    Checking the return of metal_init to avoid having dead code.
    
    Coverity CID: 190932
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Commits on Mar 15, 2019
  1. samples: can: Check return of can_attach_isr

    ceolin authored and galak committed Mar 14, 2019
    Problem spotted by coverity, CID 195786
    
    Fixes #14417
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Commits on Mar 7, 2019
  1. x86: core: Remove extra parenthesis

    ceolin authored and nashif committed Mar 4, 2019
    Extra parenthis was raising a warning when building using Clang/llvm
    
    Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Older
You can’t perform that action at this time.