quark_se is missing SPI_DRV_NAME symbol

[finikorg]

After commit 55caa7b SPI_1_NAME is empty for a board quark_se_c1000_devboard

[finikorg]

@tbursztyka

[MaureenHelm]

The Kconfig symbol SPI_1_NAME is intentionally undefined for this board after this commit. The preprocessor macro CONFIG_SPI_1_NAME is still defined, but now it's generated from dts instead of Kconfig.

Excerpts from tests/drivers/spi/spi_loopback/build/zephyr/include/generated/generated_dts_board.h:

/* spi@b0001400 */
#define SNPS_DESIGNWARE_SPI_B0001400_BASE_ADDRESS       0xb0001400
#define SNPS_DESIGNWARE_SPI_B0001400_IRQ_0              3
#define SNPS_DESIGNWARE_SPI_B0001400_IRQ_0_PRIORITY     2
#define SNPS_DESIGNWARE_SPI_B0001400_IRQ_0_SENSE        32768
#define SNPS_DESIGNWARE_SPI_B0001400_LABEL              "SPI_1"                                
#define SNPS_DESIGNWARE_SPI_B0001400_SIZE               1024

#define CONFIG_SPI_1_BASE_ADDRESS       SNPS_DESIGNWARE_SPI_B0001400_BASE_ADDRESS
#define CONFIG_SPI_1_NAME               SNPS_DESIGNWARE_SPI_B0001400_LABEL                     
#define CONFIG_SPI_1_IRQ                SNPS_DESIGNWARE_SPI_B0001400_IRQ_0
#define CONFIG_SPI_1_IRQ_PRI            SNPS_DESIGNWARE_SPI_B0001400_IRQ_0_PRIORITY

[finikorg]

@MaureenHelm so should the functionality be the same as before? At the moment SPI_NAME is undefined (whatever it is called now)

[MaureenHelm]

You can't change SPI_1_NAME value in menuconfig anymore, but you can use CONFIG_SPI_1_NAME just as you did before:

zephyr/drivers/spi/spi_dw.c

Lines 594 to 597 in 92080a0

	DEVICE_AND_API_INIT(spi_dw_port_1, CONFIG_SPI_1_NAME, spi_dw_init,
	&spi_dw_data_port_1, &spi_dw_config_1,
	POST_KERNEL, CONFIG_SPI_INIT_PRIORITY,
	&dw_spi_api);

Is there a particular sample or test application that's broken?

[finikorg]

samples/net/wpanusb is not working anymore

before the change boards/x86/quark_se_c1000_devboard/Kconfig.defconfig was used to assign

config IEEE802154_CC2520_SPI_DRV_NAME
	default SPI_1_NAME

[MaureenHelm]

Ok, I see the problem now. We need to add dts bindings for the cc2520 like we did for the mcr20a.

[galak]

There are a few cleanups like this we need to make, will open another issue to catch them all.

[MaureenHelm]

Looks like this was fixed in #11428. @finikorg can you confirm?

[finikorg]

Looks like this was fixed in #11428. @finikorg can you confirm?

@MaureenHelm Works now, thanks!

[MaureenHelm]

Fixed by #11428