Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: ipv4: udp: broadcast delivery not supported #11617

Closed
rmstoi opened this issue Nov 23, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@rmstoi
Copy link
Collaborator

commented Nov 23, 2018

Zephyr drops UDP packet with broadcast destination IP and unicast MAC. According to RFC 1122 4.1.1 this scenarion should be supported by UDP: "... to use communications services (e.g., multicast or broadcast delivery) not available from TCP."

ipv4-udp-bcast-dst.pcap.gz

@jukkar

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

Works for me, perhaps this was already fixed or there was some issue during testing. Anyway, attached is a capture of an UDP packet with broadcast destination address and it was handled by zephyr just fine.

ipv4-udp-bcast-dst-example.pcapng.gz

@jukkar jukkar closed this Jan 16, 2019

@jukkar jukkar reopened this May 15, 2019

jukkar added a commit to jukkar/zephyr that referenced this issue May 15, 2019

net: ipv4: Allow UDP packets with broadcast dst address
Make sure we are able to receive UDP packets with broadcast
destination address.

Fixes zephyrproject-rtos#11617

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

jukkar added a commit to jukkar/zephyr that referenced this issue May 15, 2019

net: ipv4: Allow UDP packets with broadcast dst address
Make sure we are able to receive UDP packets with broadcast
destination address.

Fixes zephyrproject-rtos#11617

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
@rmstoi

This comment has been minimized.

Copy link
Collaborator Author

commented May 15, 2019

New pcap, with correct Zephyr MAC address.

ipv4-udp-bcast-dst2.pcap.gz

jukkar added a commit to jukkar/zephyr that referenced this issue May 15, 2019

net: ipv4: Allow UDP packets with broadcast dst address
Make sure we are able to receive UDP packets with broadcast
destination address. We check here also non-standard broadcast
address that is described in RFC 1122 chapter 3.3.6.

Fixes zephyrproject-rtos#11617

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

jukkar added a commit to jukkar/zephyr that referenced this issue May 15, 2019

net: ipv4: Allow UDP packets with broadcast dst address
Make sure we are able to receive UDP packets with broadcast
destination address. If CONFIG_NET_IPV4_ACCEPT_ZERO_BROADCAST
is set, then check here also non-standard broadcast address
that is described in RFC 1122 chapter 3.3.6.

Fixes zephyrproject-rtos#11617

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

backporting bot pushed a commit that referenced this issue May 20, 2019

net: ipv4: Allow UDP packets with broadcast dst address
Make sure we are able to receive UDP packets with broadcast
destination address. If CONFIG_NET_IPV4_ACCEPT_ZERO_BROADCAST
is set, then check here also non-standard broadcast address
that is described in RFC 1122 chapter 3.3.6.

Fixes #11617

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

jukkar added a commit that referenced this issue May 20, 2019

net: ipv4: Allow UDP packets with broadcast dst address
Make sure we are able to receive UDP packets with broadcast
destination address. If CONFIG_NET_IPV4_ACCEPT_ZERO_BROADCAST
is set, then check here also non-standard broadcast address
that is described in RFC 1122 chapter 3.3.6.

Fixes #11617

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

nashif added a commit to nashif/zephyr that referenced this issue May 21, 2019

net: ipv4: Allow UDP packets with broadcast dst address
Make sure we are able to receive UDP packets with broadcast
destination address. If CONFIG_NET_IPV4_ACCEPT_ZERO_BROADCAST
is set, then check here also non-standard broadcast address
that is described in RFC 1122 chapter 3.3.6.

Fixes zephyrproject-rtos#11617

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

nashif added a commit that referenced this issue May 21, 2019

net: ipv4: Allow UDP packets with broadcast dst address
Make sure we are able to receive UDP packets with broadcast
destination address. If CONFIG_NET_IPV4_ACCEPT_ZERO_BROADCAST
is set, then check here also non-standard broadcast address
that is described in RFC 1122 chapter 3.3.6.

Fixes #11617

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.