Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc/stm32: Remove useless package digit for STM32 SoC Kconfig symbols #16733

Closed
erwango opened this issue Jun 11, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@erwango
Copy link
Member

commented Jun 11, 2019

Is your enhancement proposal related to a problem? Please describe.

Last digit of Kconfig symbols defined in soc/arm/st_stm32/stm32XX/Kconfig.soc hold a package information (letter G in the following example):

config SOC_STM32L476XG
	bool "STM32L476XG"

This information was previously used to be able to discriminate package variants and be able to assign RAM and Flash sizes in soc/arm/st_stm32/stm32l4/Kconfig.defconfig.stm32l452xx files. In some few other cases it is also used to define variantion bewteen SoC packages (such as number of GPIO ports in STM32F1 series).
RAM and Flash sizes are now done thanks to dts files. So, in most cases, this digit has now become useless and generate confusion in series and soc porting. It could be removed.

EDIT:
Limitation to this clean up is the fact that we still need to be able to provide SoC Flag compile information for Cube file build. This is done thanks to value of SOC Kconfig flag in Kconfig.defconfig.stm32xyyyzz files. In some case, this flag contains the package information, as it is used inside STM32Cube packages and then has to be kept also in Kconfig SOC symbol.

Describe the solution you'd like
Remove this last digit and replace by X when possible.

gon1332 added a commit to gon1332/zephyr that referenced this issue Jun 14, 2019

soc: stm32: Remove package digit for STM32L496XG
Letter G is no longer needed as described in issue zephyrproject-rtos#16733.

Signed-off-by: Ioannis Konstantelias <ikonstadel@gmail.com>

erwango added a commit to erwango/zephyr that referenced this issue Jun 17, 2019

soc: stm32: STM32F2: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32F2 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

erwango added a commit to erwango/zephyr that referenced this issue Jun 17, 2019

soc: stm32: STM32F4: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32F4 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

erwango added a commit to erwango/zephyr that referenced this issue Jun 17, 2019

soc: stm32: STM32F7: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32F7 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

erwango added a commit to erwango/zephyr that referenced this issue Jun 17, 2019

soc: stm32: STM32L0: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32L0 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

erwango added a commit to erwango/zephyr that referenced this issue Jun 17, 2019

soc: stm32: STM32L4: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32L4 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

erwango added a commit to erwango/zephyr that referenced this issue Jun 17, 2019

soc: stm32: STM32WB: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32WB series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

erwango added a commit to erwango/zephyr that referenced this issue Jun 17, 2019

soc: stm32: STM32L4: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32L4 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

erwango added a commit to erwango/zephyr that referenced this issue Jun 17, 2019

soc: stm32: STM32WB: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32WB series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

nashif added a commit that referenced this issue Jun 17, 2019

soc: stm32: STM32L0: Remove useless package digit
Fixes #16733, applied to STM32L0 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

nashif added a commit that referenced this issue Jun 17, 2019

soc: stm32: STM32L4: Remove useless package digit
Fixes #16733, applied to STM32L4 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

nashif added a commit that referenced this issue Jun 17, 2019

soc: stm32: STM32WB: Remove useless package digit
Fixes #16733, applied to STM32WB series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

nashif added a commit that referenced this issue Jun 17, 2019

soc: stm32: Remove package digit for STM32L496XG
Letter G is no longer needed as described in issue #16733.

Signed-off-by: Ioannis Konstantelias <ikonstadel@gmail.com>

nashif added a commit that referenced this issue Jun 18, 2019

soc: stm32: STM32F2: Remove useless package digit
Fixes #16733, applied to STM32F2 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

nashif added a commit that referenced this issue Jun 18, 2019

soc: stm32: STM32F4: Remove useless package digit
Fixes #16733, applied to STM32F4 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

nashif added a commit that referenced this issue Jun 18, 2019

soc: stm32: STM32F7: Remove useless package digit
Fixes #16733, applied to STM32F7 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

alexanderwachter added a commit to alexanderwachter/zephyr that referenced this issue Jul 2, 2019

soc: stm32: STM32L0: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32L0 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

alexanderwachter added a commit to alexanderwachter/zephyr that referenced this issue Jul 2, 2019

soc: stm32: STM32L4: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32L4 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

alexanderwachter added a commit to alexanderwachter/zephyr that referenced this issue Jul 2, 2019

soc: stm32: STM32WB: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32WB series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

alexanderwachter added a commit to alexanderwachter/zephyr that referenced this issue Jul 2, 2019

soc: stm32: Remove package digit for STM32L496XG
Letter G is no longer needed as described in issue zephyrproject-rtos#16733.

Signed-off-by: Ioannis Konstantelias <ikonstadel@gmail.com>

alexanderwachter added a commit to alexanderwachter/zephyr that referenced this issue Jul 2, 2019

soc: stm32: STM32F2: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32F2 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

alexanderwachter added a commit to alexanderwachter/zephyr that referenced this issue Jul 2, 2019

soc: stm32: STM32F4: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32F4 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>

alexanderwachter added a commit to alexanderwachter/zephyr that referenced this issue Jul 2, 2019

soc: stm32: STM32F7: Remove useless package digit
Fixes zephyrproject-rtos#16733, applied to STM32F7 series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.