Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards b_l4s5i_iot01a: invertion of user LEDS polarity #28665

Closed
ABOSTM opened this issue Sep 24, 2020 · 0 comments · Fixed by #28667
Closed

boards b_l4s5i_iot01a: invertion of user LEDS polarity #28665

ABOSTM opened this issue Sep 24, 2020 · 0 comments · Fixed by #28667
Assignees
@ABOSTM
Labels
area: Devicetree area: LED Label to identify LED subsystem bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 priority: low Low impact/importance bug

Comments

@ABOSTM
Copy link
Collaborator

ABOSTM commented Sep 24, 2020 •
edited

Describe the bug
According to schematics of board b_l4s5i_iot01a: MB1297
both user leds LD1 and LD2 are active high.

But in device tree they are set as active LOW.

 	leds {
 		compatible = "gpio-leds";
 		green_led_1: led_1 {
			gpios = <&gpioa 5 GPIO_ACTIVE_LOW>;
 			label = "User LD1";
 		};
 		green_led_2: led_2 {
			gpios = <&gpiob 14 GPIO_ACTIVE_LOW>;
 			label = "User LD2";
 		};

So when led is set to 1 (gpio_pin_set(dev, PIN, 1);) led is OFF,
where as is should be ON.
@ABOSTM ABOSTM added bug The issue is a bug, or the PR is fixing a bug area: Devicetree platform: STM32 ST Micro STM32 area: LED Label to identify LED subsystem labels Sep 24, 2020
@ABOSTM ABOSTM self-assigned this Sep 24, 2020
ABOSTM added a commit to ABOSTM/zephyr that referenced this issue Sep 24, 2020
@ABOSTM
boards: arm: b_l4s5i_iot01a: leds are active high
51c7c01 
See schematics of the board: MB1297
both user leds LD1 and LD2 are active high.

Fixes zephyrproject-rtos#28665

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
@ABOSTM ABOSTM mentioned this issue Sep 24, 2020
Merged
@erwango erwango added the priority: low Low impact/importance bug label Sep 24, 2020
MaureenHelm pushed a commit that referenced this issue Sep 24, 2020
@ABOSTM @MaureenHelm
boards: arm: b_l4s5i_iot01a: leds are active high
f6bc89c 
See schematics of the board: MB1297
both user leds LD1 and LD2 are active high.

Fixes #28665

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ABOSTM ABOSTM

Labels
area: Devicetree area: LED Label to identify LED subsystem bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

boards: arm: b_l4s5i_iot01a: leds are active high ABOSTM/zephyr
2 participants
@erwango @ABOSTM