Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcumgr: Probably incorrect error handling with udp backend #37193

Closed
eobalski opened this issue Jul 26, 2021 · 15 comments
Closed

mcumgr: Probably incorrect error handling with udp backend #37193

eobalski opened this issue Jul 26, 2021 · 15 comments
Assignees
Labels
area: mcumgr bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug Stale
Projects
Milestone

Comments

@eobalski
Copy link
Collaborator

In case there is no free space for mcumgr buffer, received data are probably
inproperly dropped smp_udp.c:114-127.

For more information refer to:
#37105
#37081

@eobalski eobalski added bug The issue is a bug, or the PR is fixing a bug area: mcumgr labels Jul 26, 2021
@cfriedt cfriedt added the priority: low Low impact/importance bug label Jul 27, 2021
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Sep 26, 2021
@eobalski eobalski removed the Stale label Sep 27, 2021
@carlescufi
Copy link
Member

@emob-nordic are you looking into this?

@eobalski
Copy link
Collaborator Author

eobalski commented Nov 9, 2021

@carlescufi I'm not. I was told in the past to write this issue so someone competent could address it later.

@nordicjm nordicjm added this to To do in mcumgr Nov 24, 2021
@carlescufi
Copy link
Member

@aunsbjerg could you please take a look at this issue?

@aunsbjerg
Copy link
Collaborator

@carlescufi I will try, but am a bit pressed for time, so it will be a few days before I can do anything

@de-nordic de-nordic moved this from To do to Bugs in mcumgr Dec 2, 2021
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jan 30, 2022
@de-nordic de-nordic removed the Stale label Jan 31, 2022
@de-nordic
Copy link
Collaborator

I'll take over. I have idea how to follow with this, although it requires change in mcumgr/lib.

@github-actions
Copy link

github-actions bot commented Apr 3, 2022

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Apr 3, 2022
@de-nordic de-nordic removed the Stale label Apr 4, 2022
@github-actions
Copy link

github-actions bot commented Jun 4, 2022

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jun 4, 2022
@de-nordic de-nordic removed the Stale label Jun 6, 2022
@github-actions
Copy link

github-actions bot commented Aug 6, 2022

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Aug 6, 2022
@de-nordic de-nordic removed the Stale label Aug 8, 2022
@carlescufi carlescufi added this to the future milestone Aug 30, 2022
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Oct 30, 2022
@de-nordic de-nordic removed the Stale label Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jan 2, 2023
mcumgr automation moved this from Bugs to Done in release 3.3 Jan 17, 2023
@nordicjm nordicjm reopened this Feb 6, 2023
mcumgr automation moved this from Done in release 3.3 to In progress Feb 6, 2023
@nordicjm nordicjm moved this from In progress to Bugs in mcumgr Feb 6, 2023
mcumgr automation moved this from Bugs to Done in release 3.4 Feb 21, 2023
@nordicjm nordicjm removed the Stale label Feb 21, 2023
@nordicjm nordicjm reopened this Feb 21, 2023
mcumgr automation moved this from Done in release 3.4 to In progress Feb 21, 2023
@nordicjm nordicjm moved this from In progress to Bugs in mcumgr Mar 8, 2023
@carlescufi carlescufi assigned nordicjm and unassigned de-nordic Apr 4, 2023
@nordicjm
Copy link
Collaborator

nordicjm commented Apr 4, 2023

@de-nordic the file has since moved and changed, what parts are wrong in the UDP handling?

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jun 4, 2023
@nordicjm
Copy link
Collaborator

nordicjm commented Jun 6, 2023

It is assumed that this is a duplicate of #44536 whereby if there are insufficient buffers to receive the command, no error response is sent.

@nordicjm nordicjm closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2023
mcumgr automation moved this from Bugs to Done in release 3.5 Jun 6, 2023
@nordicjm nordicjm moved this from Done in release 3.5 to Done in mcumgr Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: mcumgr bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug Stale
Projects
Development

No branches or pull requests

6 participants