Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: syscon: missing implementation #38737

Closed
henrikbrixandersen opened this issue Sep 22, 2021 · 1 comment · Fixed by #37424
Closed

drivers: syscon: missing implementation #38737

henrikbrixandersen opened this issue Sep 22, 2021 · 1 comment · Fixed by #37424
Assignees
@carlocaione
Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Milestone
v2.7.0

Comments

@henrikbrixandersen
Copy link
Member

Describe the bug
The syscon API (include/drivers/syscon.h) added in commit bc30598 lacks an implementation. The generic syscon driver (drivers/syscon/syscon.c) implements the API functions, but uses different naming, so linking will fail.

This was never caught by CI since there are no in-tree users/testcases/samples using the syscon driver API.

The low-impact bug fix would just be renaming the functions in drivers/syscon/syscon.c to match those of the API, but a new approach, which addresses both the missing implementation, missing tests and generalizes the functionality even more, was already approved (#37424).

I suggest we merge #37424 for v2.7.0.

Impact
The syscon API lacks an in-tree implementation.
@henrikbrixandersen henrikbrixandersen added bug The issue is a bug, or the PR is fixing a bug TSC Topics that need TSC discussion labels Sep 22, 2021
@henrikbrixandersen henrikbrixandersen added this to the v2.7.0 milestone Sep 22, 2021
@henrikbrixandersen henrikbrixandersen linked a pull request Sep 22, 2021 that will close this issue
drivers: syscon: Add support for multiple regions & emulator #37424
Merged
@carlocaione
Copy link
Collaborator

Weird, I wonder if something went wrong on my side when pushing. Anyway, merging #37424 sounds good to me.

@henrikbrixandersen henrikbrixandersen removed the TSC Topics that need TSC discussion label Sep 22, 2021
@nashif nashif added the priority: medium Medium impact/importance bug label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlocaione carlocaione

Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging a pull request may close this issue.

drivers: syscon: Add support for multiple regions & emulator yperess/zephyr
3 participants
@nashif @carlocaione @henrikbrixandersen