Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth: host: Implicit sc_indicate declaration when Service Changed is disabled #54813

Closed
MarekPieta opened this issue Feb 14, 2023 · 0 comments · Fixed by #54781
Closed

Bluetooth: host: Implicit sc_indicate declaration when Service Changed is disabled #54813

MarekPieta opened this issue Feb 14, 2023 · 0 comments · Fixed by #54781
Assignees
@jhedberg
Labels
area: Bluetooth Host area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@MarekPieta
Copy link
Collaborator

Describe the bug
Calling sc_indicate in bt_gatt_encrypt_change (subsys/bluetooth/host/gatt.c) may result in an implicit sc_indicate declaration build issue when Service Changed is disabled. We could ensure that the function would not be called if feature is not supported in the configuration.

Environment (please complete the following information):
Current main branch: 839050b9947a125af17ce454ece1891555cc3121
@MarekPieta MarekPieta added the bug The issue is a bug, or the PR is fixing a bug label Feb 14, 2023
MarekPieta added a commit to MarekPieta/zephyr that referenced this issue Feb 14, 2023
@MarekPieta
Bluetooth: host: Fix SC indication on encrypt change
5231a33 
The SC indication can be sent only if the GATT Service Changed is
enabled in the configuration. Change fixes build issues related to
implicit sc_indicate declaration when Service Changed is disabled.

Fixes: zephyrproject-rtos#54813

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
@MarekPieta MarekPieta mentioned this issue Feb 14, 2023
Closed
MarekPieta added a commit to MarekPieta/zephyr that referenced this issue Feb 14, 2023
@MarekPieta
Bluetooth: host: Fix SC indication on encrypt change
2dc0d1f 
The SC indication can be sent only if the GATT Service Changed is
enabled in the configuration. Change fixes build issues related to
implicit sc_indicate declaration when Service Changed is disabled.

Fixes: zephyrproject-rtos#54813

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
MarekPieta added a commit to MarekPieta/zephyr that referenced this issue Feb 15, 2023
@MarekPieta
Bluetooth: host: Fix SC indication on encrypt change
a005ed6 
The SC indication can be sent only if the GATT Service Changed is
enabled in the configuration. Change fixes build issues related to
implicit sc_indicate declaration when Service Changed is disabled.

Fixes: zephyrproject-rtos#54813

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
jori-nordic pushed a commit to jori-nordic/zephyr that referenced this issue Feb 15, 2023
@MarekPieta @jori-nordic
Bluetooth: host: Fix SC indication on encrypt change
574f910 
The SC indication can be sent only if the GATT Service Changed is
enabled in the configuration. Change fixes build issues related to
implicit sc_indicate declaration when Service Changed is disabled.

Fixes: zephyrproject-rtos#54813

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
@jori-nordic jori-nordic mentioned this issue Feb 15, 2023
Merged
stephanosio pushed a commit that referenced this issue Feb 15, 2023
@MarekPieta @stephanosio
Bluetooth: host: Fix SC indication on encrypt change
aed165d 
The SC indication can be sent only if the GATT Service Changed is
enabled in the configuration. Change fixes build issues related to
implicit sc_indicate declaration when Service Changed is disabled.

Fixes: #54813

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
dipanjan115 pushed a commit to dipanjan115/zephyr that referenced this issue Mar 8, 2023
@MarekPieta @nordicjm
[nrf fromtree] Bluetooth: host: Fix SC indication on encrypt change
0e0d569 
The SC indication can be sent only if the GATT Service Changed is
enabled in the configuration. Change fixes build issues related to
implicit sc_indicate declaration when Service Changed is disabled.

Fixes: zephyrproject-rtos#54813

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
(cherry picked from commit aed165d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhedberg jhedberg

Labels
area: Bluetooth Host area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
3 participants
@jhedberg @laurenmurphyx64 @MarekPieta