pinmux subsystem API is undocumented and does not enforce validation #7390
Labels
area: Pinmux
bug
The issue is a bug, or the PR is fixing a bug
priority: low
Low impact/importance bug
Comments
andrewboie
pushed a commit
to andrewboie/zephyr
that referenced
this issue
May 7, 2018
The pinmux subsystem does not have any API documenation. Currently none of the existing pinmux drivers do any kind of input validation for the pin/op parameters, which has been shown to allow the caller to access unauthorized memory, up to and including disabling the MPU. This requires a proper specification for the pinmux subsystem and also modification of existingd drivers to validate arguments on a per driver basis. Remove user mode access until zephyrproject-rtos#7390 is resolved. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
nashif
pushed a commit
that referenced
this issue
May 8, 2018
The pinmux subsystem does not have any API documenation. Currently none of the existing pinmux drivers do any kind of input validation for the pin/op parameters, which has been shown to allow the caller to access unauthorized memory, up to and including disabling the MPU. This requires a proper specification for the pinmux subsystem and also modification of existingd drivers to validate arguments on a per driver basis. Remove user mode access until #7390 is resolved. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
|
@andrewboie Will you please rewrite this such that it describes what needs to be done, rather than just describing the current state of affairs? Something like "Add documentation to the pinmux APIs" and "Validate pinmux API inputs". I'd like to tag this issue as an enhancement, but that doesn't make sense with the current description. |
nashif
added
bug
|
pinmux system will be completely overhauled and replaced, so closing this old issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
None of the pinmux APIs in include/pinmux.h have any documentation.
In addition, if we are to expose pinmux APIs to user mode, we are going to need the specification to enforce that drivers validate the parameters passed in. Currently the pinmux drivers don't validate any inputs, and a user thread using these APIs have been demonstrated writing to memory that it should not have access to or even disable the MPU.
Until this is done, the pinmux subsystem APIs are being removed from user mode access.
The text was updated successfully, but these errors were encountered: