Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-ASCII / non-UTF-8 files in ext/ #8462

Closed
dbkinder opened this issue Jun 18, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@dbkinder
Copy link
Contributor

commented Jun 18, 2018

While it doesn't seem to be a problem (yet), there are 90 files total in the ext/hal/st/stm32cube and ext/hal/ti/simplelink/source/ti/ folders that are not ASCII nor UTF-8 encoded. (Looks like they have windows-1252 characters in them such as a em-dash and single-quote.)

./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l476xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l432xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l4s7xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l4a6xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l433xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l496xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l475xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l462xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l4r5xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l4r7xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l4xx.h:                                                           unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l4s5xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l451xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l471xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l4r9xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l486xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l443xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l4s9xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l452xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l485xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l431xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32l4xx/soc/stm32l442xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f318xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f303xc.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f301x8.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f302xc.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f303xe.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f302x8.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f358xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f328xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f373xc.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f334x8.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f302xe.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f398xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f378xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f303x8.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f3xx/soc/stm32f3xx.h:                                                           unknown-8bit
./ext/hal/st/stm32cube/stm32f7xx/soc/stm32f779xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f7xx/soc/stm32f767xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f7xx/soc/stm32f745xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f7xx/soc/stm32f765xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f7xx/soc/stm32f723xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f7xx/soc/stm32f732xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f7xx/soc/stm32f722xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f7xx/soc/stm32f746xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f7xx/soc/stm32f733xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f7xx/soc/stm32f7xx.h:                                                           unknown-8bit
./ext/hal/st/stm32cube/stm32f7xx/soc/stm32f756xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f7xx/soc/stm32f777xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f7xx/soc/stm32f769xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f101xe.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f101xb.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f101xg.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f100xb.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f102x6.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f103xg.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f103xb.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f103xe.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f100xe.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f1xx.h:                                                           unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f101x6.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f103x6.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f107xc.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f105xc.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f1xx/soc/stm32f102xb.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f091xc.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f071xb.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f038xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f098xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f0xx.h:                                                           unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f030x8.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f030x6.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f078xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f048xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f070xb.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f070x6.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f031x6.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f051x8.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f072xb.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f030xc.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f058xx.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f0xx/soc/stm32f042x6.h:                                                         unknown-8bit
./ext/hal/st/stm32cube/stm32f4xx/soc/stm32f4xx.h:                                                           unknown-8bit
./ext/hal/ti/simplelink/source/ti/drivers/net/wifi/wlan.h:                                                  unknown-8bit
./ext/hal/ti/simplelink/source/ti/drivers/net/wifi/netutil.h:                                               unknown-8bit
./ext/hal/ti/simplelink/source/ti/drivers/net/wifi/sl_socket.h:                                             unknown-8bit
./ext/hal/ti/simplelink/source/ti/devices/cc32xx/inc/hw_common_reg.h:                                       unknown-8bit
./ext/hal/ti/simplelink/source/ti/devices/cc32xx/inc/hw_aes.h:                                              unknown-8bit
./ext/hal/ti/simplelink/source/ti/devices/cc32xx/inc/hw_hib3p3.h:                                           unknown-8bit
./ext/hal/ti/simplelink/source/ti/devices/cc32xx/inc/hw_dthe.h:                                             unknown-8bit
@nashif

This comment has been minimized.

Copy link
Member

commented Jun 19, 2018

Those are external files that we should not touch and change, they should work as is, what is the potential problem with those?

@nashif

This comment has been minimized.

Copy link
Member

commented Jul 13, 2018

Can;t do much about those files, they are external

@nashif nashif closed this Jul 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.