MSPI NOR Flash Driver doesn't indicate support for `FLASH_PAGE_LAYOUT`

[danieldegrasse]

Describe the bug

The MSPI NOR Flash driver, drivers/flash/flash_mspi_nor.c includes support for flash page layout APIs:

zephyr/drivers/flash/flash_mspi_nor.c

Line 598 in 6750f4a

#if defined(CONFIG_FLASH_PAGE_LAYOUT)

, but does not select CONFIG_FLASH_HAS_PAGE_LAYOUT.

This means that applications like MCUBoot which require the flash page layout API cannot build with this driver. While no in tree boards exist that only use this flash driver, the out of tree board I am using encounters this issue.

Regression

• This is a regression.

Steps to reproduce

To reproduce:

1. west build -p always -b nrf9280pdk//cpuapp samples/drivers/flash_shell/ -DCONFIG_FLASH_PAGE_LAYOUT=y -DCONFIG_MSPI=y -DCONFIG_SOC_FLASH_NRF_MRAM=n
2. Note that CONFIG_FLASH_PAGE_LAYOUT is not selected when it should be

Relevant log output

warning: FLASH_PAGE_LAYOUT (defined at drivers/flash/Kconfig:142) was assigned the value 'y' but got
the value 'n'. Check these unsatisfied dependencies: FLASH_HAS_PAGE_LAYOUT (=n). See
http://docs.zephyrproject.org/latest/kconfig.html#CONFIG_FLASH_PAGE_LAYOUT and/or look up
FLASH_PAGE_LAYOUT in the menuconfig/guiconfig interface. The Application Development Primer, Setting
Configuration Values, and Kconfig - Tips and Best Practices sections of the manual might be helpful
too.

Impact

Annoyance – Minor irritation; no significant impact on usability or functionality.

Environment

• OS: Ubuntu 22.04
• Toolchain: Zephyr SDK 0.17.4