Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boards] Add debug capability to Silabs TB2 #11211

Merged
merged 1 commit into from Nov 8, 2018
Merged

[boards] Add debug capability to Silabs TB2 #11211

merged 1 commit into from Nov 8, 2018

Conversation

ekarlso
Copy link
Contributor

@ekarlso ekarlso commented Nov 8, 2018

No description provided.

@galak galak added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Nov 8, 2018
Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the commit message something like:

'boards: efr32mg_sltb004a: ...'

We don't tend to use '[ ]' in commit message headers.

@galak galak added the platform: SiLabs Silicon Labs label Nov 8, 2018
@ekarlso
Copy link
Contributor Author

ekarlso commented Nov 8, 2018

Done

@codecov-io
Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #11211 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11211      +/-   ##
==========================================
- Coverage    53.1%   52.97%   -0.14%     
==========================================
  Files         218      218              
  Lines       26883    26870      -13     
  Branches     5952     5951       -1     
==========================================
- Hits        14277    14235      -42     
- Misses      10172    10197      +25     
- Partials     2434     2438       +4
Impacted Files Coverage Δ
subsys/logging/log_output.c 63.59% <0%> (-8.74%) ⬇️
subsys/logging/log_core.c 68.34% <0%> (-3.59%) ⬇️
misc/printk.c 85.45% <0%> (-3.1%) ⬇️
include/logging/log_msg.h 89.09% <0%> (-1.82%) ⬇️
include/logging/log_core.h 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5315340...23f2fd8. Read the comment docs.

@galak
Copy link
Collaborator

galak commented Nov 8, 2018

@chrta look good to you?

@chrta
Copy link
Collaborator

chrta commented Nov 8, 2018

Yes, looks good.

This makes it possible to "ninja debug" to start debugging
towards the onboard debugger of the TB2 board.

Signed-off-by: Endre Karlson <endre.karslon@gmail.com>
@MaureenHelm MaureenHelm merged commit 0757b61 into zephyrproject-rtos:master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: SiLabs Silicon Labs Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants