Promiscuous mode off fixes #11303
Merged
Promiscuous mode off fixes #11303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbursztyka
reviewed
Nov 12, 2018
subsys/net/ip/net_if.c
Outdated
| return; | ||
| } | ||
|
|
||
| #if defined(CONFIG_NET_L2_ETHERNET) |
There was a problem hiding this comment.
Could you try using IS_ENABLED instead?
There was a problem hiding this comment.
This is currently not possible as the ETHERNET symbol is only available if CONFIG_NET_L2_ETHERNET is set. But I can refactor the functions a bit more in order to avoid duplication. I will send a new version.
Codecov Report
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
+ Coverage 51.55% 51.56% +<.01%
==========================================
Files 216 216
Lines 27665 27671 +6
Branches 6937 6938 +1
==========================================
+ Hits 14263 14268 +5
- Misses 10653 10654 +1
Partials 2749 2749
Continue to review full report at Codecov.
|
|
New version:
|
Pass the promiscuous mode OFF event properly to device driver instead of just toggling the network interface flag. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Add a shell that implements "promisc [on | off] <interface>" command to toggle promiscuous mode support. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
tbursztyka
approved these changes
Nov 13, 2018
pfalcon
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.