New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell: Allocate proper amount of history slab memory #13048
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13048 +/- ##
=======================================
Coverage 48.63% 48.63%
=======================================
Files 313 313
Lines 46436 46436
Branches 10710 10710
=======================================
Hits 22585 22585
Misses 19395 19395
Partials 4456 4456
Continue to review full report at Codecov.
|
|
i will improve history handling in the future in terms of ram used as current solution is not optimal but let's get that in so that goes to 1.14. |
b2db7d1
to
237b817
Compare
|
reduced number of buffers by 1 to offset memory cost of increasing the overall per buffer size. |
237b817
to
09d2815
Compare
|
Found a nice issue with k_mem_slab allowing for non-aligned block size. So added in ROUND_UP() to fix that. |
This patch increases the amount of slab memory per item for the shell history to match the maximum command input buffer size plus the accounting information for the dnode list item. Signed-off-by: Andy Gross <andy.gross@linaro.org>
09d2815
to
0d8a8aa
Compare
This patch increases the amount of slab memory per item for the shell
history to match the maximum command input buffer size plus the
accounting information for the dnode list item.
Signed-off-by: Andy Gross andy.gross@linaro.org