cmake: strip_nondeterminism_if_found() on all .a library files #17494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Post process libraries if find_program(strip-nondeterminism) succeeds, do nothing otherwise. This has been successfully tested on Ubuntu 18.04 with a full sanitycheck run including all the default samples/ and tests/ Two very important caveats: 1. This required a couple of fixes on top of "apt-get install non-determinism" version 0.040-1.1~build1. These fixes are available at https://github.com/marc-hb/strip-nondeterminism/commits/ar-handler-fixes 2. The entire ar.pm handler has been removed in more recent (1.0.0+) strip-nondeterminism releases! The commit message 366d60c9cc16 says: "Drop .ar handler; binutils is reproducible". The corresponding bugs and discussions seem to show a concern than ar.pm could hide bugs in binutils or llvm-ar. Supporting older or non-debian systems doesn't seem to be desired. So the preferred alternative is to use a toolchain like the Zephyr SDK that supports creating deterministic .a files and (if not the default) pass the -D option to (GNU) ar thanks to CMAKE_LANG_CREATE_STATIC_LIBRARY Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
ar -D is submitted for the Zephyr SDK in PR #17495 |
|
See https://salsa.debian.org/reproducible-builds/strip-nondeterminism/issues/3 |
|
FYI I plan to work on this over the next week or so and thus a custom package will not be required. |
github-actions
bot
added
has-conflicts
|
stale for almost a year... |
|
Nod. From quickly loading this back into my brain, what we did in |
|
In the mean time crosstool-ng finally caught up with other toolchains and finally turn on At least for the Zephyr SDK that is. Other toolchains are free to resubmit this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Post process libraries if find_program(strip-nondeterminism) succeeds,
do nothing otherwise.
This has been successfully tested on Ubuntu 18.04 with a full
sanitycheck run including all the default samples/ and tests/
Two very important caveats:
This required a couple of fixes on top of "apt-get install
non-determinism" version 0.040-1.1~build1. These fixes are available
at https://salsa.debian.org/reproducible-builds/strip-nondeterminism/merge_requests/4
The entire ar.pm handler has been removed in more recent (1.0.0+)
strip-nondeterminism releases! The commit message 366d60c9cc16 says:
"Drop .ar handler; binutils is reproducible". The corresponding bugs
and discussions seem to show a concern than ar.pm could hide bugs in
binutils or llvm-ar. Supporting older or non-debian systems doesn't
seem to be desired.
So the preferred alternative is to use a toolchain like the Zephyr SDK
that supports creating deterministic .a files and (if not the default)
pass the -D option to (GNU) ar thanks to
CMAKE_LANG_CREATE_STATIC_LIBRARY
Signed-off-by: Marc Herbert marc.herbert@intel.com