Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for Actions Semi ATB1103 MCU and EVB #20984
Conversation
This comment has been minimized.
This comment has been minimized.
|
All checks are passing now. checkpatch (informational only, not a failure)
Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
a5ed0ee
to
939c657
|
docs LGTM, thanks. |
This comment has been minimized.
This comment has been minimized.
|
@galak Any update on this PR? |
This comment has been minimized.
This comment has been minimized.
|
@Mani-Sadhasivam there seems to be a conflict with upstream (with There are also essentially no reviews from codeowners, so could the assigned reviewers please take a look? |
Add SoC support for Actions Semi ATB1103 MCU. ATB1103 MCU comes from ATB110X family of Actions Semi and has below features: * CPU - ARM Cortex-M0 * RAM - 40KB * ROM - 160KB * Integrated Flash - 4MB * Bluetooth 4.2 More information about this MCU can be found in Actions product page: http://www.actions-semi.com/en/productview.aspx?id=234 Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Add clock driver support for Actions CMU (Clock Management Unit). CMU is responsible for managing clocks in ATB110X MCUs. Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
939c657
to
9b2fdb6
This comment has been minimized.
This comment has been minimized.
|
@Mani-Sadhasivam can you address the 'nit' CI check issue. |
Add UART driver support for Actions Semi MCUs. The UART driver has been used in ATB110X series MCUs. Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Add board support for ATB1103 Golden Board from Actions Semi. This board is powered by Actions Semi ATB1103 MCU. Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Add myself as the codeowner for Actions Semi stuffs. Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
6012cbd
to
035a0b6
This comment has been minimized.
This comment has been minimized.
|
@galak Done |
| @@ -167,6 +170,8 @@ | |||
| /drivers/sensor/lps*/ @avisconti | |||
| /drivers/sensor/lsm*/ @avisconti | |||
| /drivers/sensor/st*/ @avisconti | |||
| /drivers/serial/Kconfig.acts @Mani-Sadhasivam | |||
| /drivers/serial/uart_acts.c @Mani-Sadhasivam | |||
This comment has been minimized.
This comment has been minimized.
| @@ -0,0 +1,7 @@ | |||
| # Copyright (c) 2019 Actions (Zhuhai) Technology Co., Ltd | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
galak
Jan 29, 2020
Contributor
Ah, see you commented in the PR on this. Is there a reference to their original code?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Mani-Sadhasivam
Jan 29, 2020
Author
Collaborator
Ah, see you commented in the PR on this. Is there a reference to their original code?
No. They just shared a zip file with me based on LTS version and I had to clean a lot for upstream.
| @@ -0,0 +1,6 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
This comment has been minimized.
This comment has been minimized.
|
Can you shrink the boards/arm/atb1103_golden/doc/img/atb1103_golden.jpg, 4M is kinda big. |
|
The compats for DTS, do you think the names cover other actions semi MCUs? Just wondering if there is some family name or something to use? |
| return err; | ||
|
|
||
| /* Enable receiver and transmitter */ | ||
| uart->ctrl = ((0x1 << 31) | (0x1 << 30) | (0x1 << 23) | (0x1 << 22) | |
This comment has been minimized.
This comment has been minimized.
| }; | ||
|
|
||
| static struct uart_acts_dev_data uart_acts_dev_data_0 = { | ||
| .baud_rate = 115200, |
This comment has been minimized.
This comment has been minimized.
| #ifdef CONFIG_UART_INTERRUPT_DRIVEN | ||
| static void uart_acts_irq_config_0(struct device *port) | ||
| { | ||
| IRQ_CONNECT(IRQ_ID_UART0, |
This comment has been minimized.
This comment has been minimized.
| # must be >= the highest interrupt number used | ||
| default 32 | ||
|
|
||
| config ISR_STACK_SIZE |
This comment has been minimized.
This comment has been minimized.
| */ | ||
|
|
||
| . = 0xc0; | ||
| LONG(0x00425441); |
This comment has been minimized.
This comment has been minimized.
| acts_request_rc_3M(false); | ||
|
|
||
| /* Remap Vector base address */ | ||
| sys_write32(0x01000000, VECTOR_BASE); |
This comment has been minimized.
This comment has been minimized.
| #ifndef _ACTIONS_SOC_IRQ_H_ | ||
| #define _ACTIONS_SOC_IRQ_H_ | ||
|
|
||
| #define IRQ_ID_TIMER0 0 |
This comment has been minimized.
This comment has been minimized.
|
|
||
| #define PMU_REG_BASE 0x40008000 | ||
| #define ADC_REG_BASE 0x40008010 | ||
|
|
This comment has been minimized.
This comment has been minimized.
| #ifndef _ACTIONS_SOC_RESET_H_ | ||
| #define _ACTIONS_SOC_RESET_H_ | ||
|
|
||
| #define RESET_ID_DMA 0 |
This comment has been minimized.
This comment has been minimized.
|
Mostly looks good, a number of cleanup comments. |
This comment has been minimized.
This comment has been minimized.
Thanks. I'll address them soon. |
Mani-Sadhasivam commentedNov 25, 2019
Hello,
This PR adds support for Actions Semi ATB1103 MCU and its evaluation board. ATB1103 is part of the Low power Bluetooth MCUs family (ATB110X) from Actions Semi. The target applications for this MCU are BLE Voice Remote, Smart wearable devices, Smart Home sensors, and BT Mesh device applications. The EVB (Golden board) is designed and manufactured by Actions Semi for their internal use but there are few commercial target boards available for this MCU as well.
This PR is based on the initial code support for the MCU and board developed by Actions Semi and hence the copyrights are shared based on the contributions.
Thanks,
Mani