cmake: fix the build on windows #26783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit ef3c5e5 changed the way WEST_TOPDIR is initialized from calling 'west topdir' as a subprocess to using the west API. However, WEST_TOPDIR is a cmake variable and must be a cmake-style path, with forward slashes. While 'west topdir' as a command does output a forward slash separated path (basically in order to make the zephyr build system work), west_topdir() as an API returns the path in the host environment path style, which on Windows uses backslashes. This turns out to be the ultimate cause of the following build error: CMake Error at C:/.../CheckCCompilerFlag.cmake:41 (set): Syntax error in cmake code when parsing string -fmacro-prefix-map=C:\Users\Marti\zp=WEST_TOPDIR Fix it by converting to POSIX style in Python. We could have potentially also done this using file(TO_CMAKE_PATH "${WEST_TOPDIR}" ...), but I'm intentionally repeating the old way of doing things since it was known to work. Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
mbolivar-nordic
requested review from
nashif,
MaureenHelm,
tejlmand,
carlescufi and
galak
mbolivar-nordic
added
Hotfix
MaureenHelm
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
I reproduced the issue in master (d0e36f2) and can confirm this PR fixes it.
nashif
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ef3c5e5 changed the way
WEST_TOPDIR is initialized from calling 'west topdir' as a subprocess
to using the west API.
However, WEST_TOPDIR is a cmake variable and must be a cmake-style
path, with forward slashes. While 'west topdir' as a command does
output a forward slash separated path (basically in order to make the
zephyr build system work), west_topdir() as an API returns the path in
the host environment path style, which on Windows uses backslashes.
This turns out to be the ultimate cause of the following build error:
Fix it by converting to POSIX style in Python. We could have
potentially also done this using file(TO_CMAKE_PATH "${WEST_TOPDIR}"
...), but I'm intentionally repeating the old way of doing things
since it was known to work.
Signed-off-by: Martí Bolívar marti.bolivar@nordicsemi.no