Bluetooth: controller: Fix ull_conn LSTO for must_expire #30132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When CONFIG_BT_CTLR_CONN_META is enabled and the ticker "must_expire" feature is used, collisions may cause incorrect decrement of the supervision_expire counter, resulting in a too early link supervision timeout. Signed-off-by: Morten Priess <mtpr@oticon.com>
mtpr-ot
changed the title
mtpr-ot
force-pushed
the
feature/conn_lsto_and_force
branch
from
cad218c
to
ab5c0f0
Compare
|
Can't seem to get CI passing - looks unrelated. |
mtpr-ot
requested review from
carlescufi,
cvinayak,
kruithofa and
thoh-ot
as code owners
cvinayak
requested changes
Nov 21, 2020
There was a problem hiding this comment.
Separate into two different PRs, so that I can approve the Random Forced scheduling Kconfig.
Regarding is_must_expire, please add a simple upstream test to cover it, so that any future upstream regressions get caught of the features that not enabled by default in upstream samples.
subsys/bluetooth/controller/Kconfig
Outdated
| @@ -353,6 +353,16 @@ config BT_CTLR_CONN_RSSI | |||
| help | |||
| Enable connection RSSI measurement. | |||
|
|
|||
| config BT_CTLR_CONN_RANDOM_FORCE | |||
| bool "Enable random forced sceduling for peripheral on missed anchor point" | |||
There was a problem hiding this comment.
Suggested change
| bool "Enable random forced sceduling for peripheral on missed anchor point" | |
| bool "Random forced scheduling for peripheral on missed anchor point" |
subsys/bluetooth/controller/Kconfig
Outdated
Comment on lines
361
to
364
| When enabled, controller will have legacy behavior and force priority at | ||
| next ticker scheduling, if anchor point is missed. | ||
| Note that this overrides general priority- and round-robin connection | ||
| scheduling for peripheral. |
There was a problem hiding this comment.
Suggested change
| When enabled, controller will have legacy behavior and force priority at | |
| next ticker scheduling, if anchor point is missed. | |
| Note that this overrides general priority- and round-robin connection | |
| scheduling for peripheral. | |
| When enabled, controller will have legacy behavior and randomly force | |
| priority at next ticker scheduling for peripheral role, if anchor point is | |
| missed. | |
| Two are more connections with similar interval on a device connected | |
| to a peer device having two or more connections at its end with same | |
| interval could lock to a round robin pattern where in neither of the central | |
| nor peripheral event would be in sync at either end. Randomness allows | |
| to break this locked round robin pattern permitting an anchor point sync. |
There was a problem hiding this comment.
Split into two PRs
mtpr-ot
force-pushed
the
feature/conn_lsto_and_force
branch
from
ab5c0f0
to
baff72d
Compare
mtpr-ot
changed the title
cvinayak
approved these changes
Nov 23, 2020
kruithofa
approved these changes
Nov 23, 2020
Can this be a part of a later PR? I need to figure out how to create a test running on upstream code, without support for the "must_expire" feature in Nordic ULL. Ant ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CONFIG_BT_CTLR_CONN_META is enabled and the ticker "must_expire"
feature is used, collisions may cause incorrect decrement of the
supervision_expire counter, resulting in a too early link supervision
timeout.