Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: sensor: mcp9600: Added driver and sample for mcp9600 #31082

Closed
wants to merge 5 commits into from

Conversation

@riedlse
Copy link

@riedlse riedlse commented Jan 3, 2021

Added driver and sample for mcp9600 microchip I2C thermocouple
amplifier. Tested on frdm_kw41z and nrf52850dk.

Signed-off-by: Steven Riedl steve@serconsultingllc.com

Copy link
Collaborator

@pabigot pabigot left a comment

Please also squash the commits and update the description to cover the content of the PR.

drivers/sensor/mcp9600/mcp9600.c Outdated Show resolved Hide resolved
drivers/sensor/mcp9600/mcp9600.c Outdated Show resolved Hide resolved
drivers/sensor/mcp9600/mcp9600.c Outdated Show resolved Hide resolved
drivers/sensor/mcp9600/mcp9600.h Outdated Show resolved Hide resolved
drivers/sensor/mcp9600/mcp9600_trigger.c Outdated Show resolved Hide resolved
samples/sensor/mcp9600/README.rst Show resolved Hide resolved
samples/sensor/mcp9600/src/main.c Outdated Show resolved Hide resolved
Added driver and sample for mcp9600 microchip I2C thermocouple
amplifier. Tested on frdm_kw41z and nrf52850dk.

Fixed multiple comments on the code. Tested fixes

Signed-off-by: Steven Riedl <steve@serconsultingllc.com>
@riedlse riedlse force-pushed the riedlse:sensor_mcp9600 branch from 73856ed to e0de553 Jan 6, 2021
editing error on readme no newline at end

Signed-off-by: Steven Riedl <steve@serconsultingllc.com>
@riedlse riedlse requested a review from pabigot Jan 6, 2021
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Thanks for the contribution!

drivers/sensor/CMakeLists.txt Outdated Show resolved Hide resolved
drivers/sensor/CMakeLists.txt Outdated Show resolved Hide resolved
drivers/sensor/mcp9600/mcp9600.c Outdated Show resolved Hide resolved
drivers/sensor/mcp9600/mcp9600.c Outdated Show resolved Hide resolved
samples/sensor/mcp9600/CMakeLists.txt Outdated Show resolved Hide resolved
samples/sensor/mcp9600/README.rst Show resolved Hide resolved
drivers/sensor/mcp9600/Kconfig Outdated Show resolved Hide resolved
drivers/sensor/mcp9600/CMakeLists.txt Outdated Show resolved Hide resolved
samples/sensor/mcp9600/sample.yaml Show resolved Hide resolved
samples/sensor/mcp9600/README.rst Outdated Show resolved Hide resolved
samples/sensor/mcp9600/README.rst Show resolved Hide resolved
samples/sensor/mcp9600/prj.conf Outdated Show resolved Hide resolved
samples/sensor/mcp9600/prj.conf Outdated Show resolved Hide resolved
samples/sensor/mcp9600/src/main.c Outdated Show resolved Hide resolved
drivers/sensor/mcp9600/mcp9600.c Outdated Show resolved Hide resolved
drivers/sensor/mcp9600/mcp9600.c Outdated Show resolved Hide resolved
drivers/sensor/mcp9600/mcp9600.c Outdated Show resolved Hide resolved
@pabigot
Copy link
Collaborator

@pabigot pabigot commented Jan 7, 2021

Also: squash the second commit which fixes a whitespace issue diagnosed in the first commit. Unless @MaureenHelm wants the sample in a separate commit from the driver as with #31064; that's not an expectation I have.

Re #31064 (comment)

OK, will pull this one and do separate, I guess driver has to go first and be merged?

No, put both commits in the same PR, driver first, then sample.

riedlse added 3 commits Jan 7, 2021
Split driver and sample in to seperate commits.

This is the entire driver functionality to read the
temperature of a K type thermocouple. Additional code
will be needed if a different type is used or to configure
the alarm trigger functionality.

On branch sensor_mcp9600
Your branch is up to date with 'origin/sensor_mcp9600'.

Changes to be committed:
modified:   drivers/sensor/CMakeLists.txt
modified:   drivers/sensor/Kconfig
modified:   drivers/sensor/mcp9600/CMakeLists.txt
modified:   drivers/sensor/mcp9600/Kconfig
modified:   drivers/sensor/mcp9600/mcp9600.c
modified:   drivers/sensor/mcp9600/mcp9600.h
modified:   dts/bindings/sensor/microchip,mcp9600.yaml

Signed-off-by: Steven Riedl <steve@serconsultingllc.com>
Sample code for using the mcp9600 driver. Sample only
commit.

Signed-off-by: Steven Riedl <steve@serconsultingllc.com>

On branch sensor_mcp9600
Your branch is up to date with 'origin/sensor_mcp9600'.

Changes to be committed:
modified:   samples/sensor/mcp9600/CMakeLists.txt
modified:   samples/sensor/mcp9600/README.rst
deleted:    samples/sensor/mcp9600/boards/nrf52840dongle_nrf52840.overlay
modified:   samples/sensor/mcp9600/prj.conf
modified:   samples/sensor/mcp9600/sample.yaml
modified:   samples/sensor/mcp9600/src/main.c
copy paste error included another driver I am working on that
will be in a later contribution. deleted offending lines.

On branch sensor_mcp9600
Your branch is up to date with 'origin/sensor_mcp9600'.

Changes to be committed:
modified:   drivers/sensor/CMakeLists.txt
modified:   drivers/sensor/Kconfig

Signed-off-by: Steven Riedl <steve@serconsultingllc.com>
@riedlse
Copy link
Author

@riedlse riedlse commented Feb 17, 2021

Don't have time to finish this right now, will probably resubmit later, with proper multi-device support

@riedlse
Copy link
Author

@riedlse riedlse commented Feb 17, 2021

wanted to close on last comment

@riedlse riedlse closed this Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants