Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel tests: fatal: added "ignore_faults" tag #52

Closed

Conversation

rishikha
Copy link
Contributor

@rishikha rishikha commented May 2, 2017

added tag : ignore_faults

Signed-off-by: Rishi Khare rishi.khare@intel.com

added tag : ignore_faults

Signed-off-by: Rishi Khare <rishi.khare@intel.com>
Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We know you updated this file, in the title of the commit, explain what the change does instead and why we need it rather than mentioning the files you have changed, for example:

tests: fatal: add ignore_faults tag

This test generates a fault as part of the test, make the
test-suite aware of that by tagging it as such.

This test generates a fault as part of the test,hence make the
 test-suite aware of that by tagging it.

Signed-off-by: Rishi Khare <rishi.khare@intel.com>
@rishikha rishikha changed the title updated tests/kernel/stackprot/testcase.ini kernel tests: fatal: added "ignore_faults" tag May 3, 2017
@rishikha rishikha closed this May 3, 2017
@rishikha rishikha deleted the fix_kernel_test_tag branch May 3, 2017 06:42
@xusiwei
Copy link

xusiwei commented May 3, 2017

I think you shouldn't makes a trivial commit in your PR, likes "Merge branch 'master' into fix_kernel_test_tag".

@rishikha
Copy link
Contributor Author

rishikha commented May 3, 2017

yes it was just a mistake .. I am all-together discarding this pull..

nagineni pushed a commit to nagineni/zephyr that referenced this pull request Nov 20, 2017
…-rtos#52)

* [jsrunner] Added a QEMU option to run QEMU after build

 - The only way previously to do this was to build with
   jsrunner, then run make BOARD=qemu_x86 qemu

Signed-off-by: James Prestwood <james.prestwood@intel.com>

* [QEMU] Modified source for QEMU build

Signed-off-by: James Prestwood <james.prestwood@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants