Bluetooth: BAP: Fix issue with setting invalid iso data path #67835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
bap_iso_path_fix
branch
2 times, most recently
from
acc1788 to
ab032e3
Compare
BAP would always set up the ISO data path in both directions, even for unidirectional CIS. This meant that in the unconfigured direction, the data path configuration data would all be 0, which causes issues on some controllers. The new refactored approach implemented by this commit will always ensure that the data path is setup correctly, and that we only set the data path in one direction for unidirectional CIS. The unset path will use the default ISO path of HCI and transparant format, which should always be allowed by a controller. This is building on the requirement in BAP that all streams in a unicast group shall be QoS configured at the same time. This ensures that before any streams in the CIG has been connected, they have all been configured. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
bap_iso_path_fix
branch
from
ab032e3 to
46630b5
Compare
zephyrbot
requested review from
Casper-Bonde-Bose,
MariuszSkamra,
asbjornsabo,
fredrikdanebjer,
jhedberg,
kruithofa,
larsgk and
sjanc
rick1082
approved these changes
Jan 22, 2024
Contributor
rick1082
left a comment
rick1082
left a comment
There was a problem hiding this comment.
Confirmed the fix works.
alexsven
approved these changes
Jan 22, 2024
Casper-Bonde-Bose
approved these changes
Jan 22, 2024
Contributor
Casper-Bonde-Bose
left a comment
Casper-Bonde-Bose
left a comment
There was a problem hiding this comment.
Looks good to me.
kruithofa
approved these changes
Jan 22, 2024
kartben
added a commit
to kartben/zephyr
that referenced
this pull request
Dec 4, 2025
Last activity: 18 months ago (review)
Recent activities:
- review: Review on 'Bluetooth: Audio: Shell: Fix build errors for USB=n'
zephyrproject-rtos#72733
(2024-05-16T06:13:15Z)
- review: Review on 'Bluetooth: ISO: Introduce bt_iso_chan_send_ts'
zephyrproject-rtos#68611
(2024-02-07T07:53:39Z)
- review: Review on 'Bluetooth: BAP: Fix issue with setting invalid iso
data path'
zephyrproject-rtos#67835
(2024-01-22T10:15:03Z)
Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BAP would always set up the ISO data path in both directions, even for unidirectional CIS. This meant that in the unconfigured direction, the data path configuration data would all be 0, which causes issues on some controllers.
The new refactored approach implemented by this commit will always ensure that the data path is setup correctly, and that we only set the data path in one direction for unidirectional CIS.
This is building on the requirement in BAP that all streams in a unicast group shall be QoS configured at the same time. This ensures that before any streams in the CIG has been connected, they have all been configured.
fixes #67779