-
Notifications
You must be signed in to change notification settings - Fork 8.3k
shell: Allow extension of shell APIs #71290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3e37dbb to
b57aea6
Compare
Similar to logging module, allow application specific extension of shell fprintf APIs at a macro level. Signed-off-by: Al Semjonovs <asemjonovs@google.com>
b57aea6 to
8d6d872
Compare
|
@asemjonovs |
Sure! I'm working on a project where I'm converting our text based logging over to tokenized logging. I found that we can get additional space savings by also tokenizing the strings that are used in the shell API's as well, since its similar to logging for us. Since the tokenizing occurs at build time, I need to intercept the macro to tokenize the string. |
nashif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a big fan of this open-ended extension method, but if we want to go with this, we would like to see a sample using this in the tree, similar to how it is done for logging. please.
Verify customized shell macro APIs Signed-off-by: Al Semjonovs <asemjonovs@google.com>
Done. Yeah, I'm not a huge fan of this as well, but I'm not sure if there's a better way? |
|
@nashif - could you give this another pass? |
Similar to logging module, allow application specific extension of shell fprintf APIs at a macro level.