west: linkserver: change to flash command line as required by v1.5.xx#71963
Merged
fabiobaltieri merged 1 commit intozephyrproject-rtos:mainfrom May 2, 2024
Merged
Conversation
There is no need to specify the core with the flash command line. This is actually rejected with linkserver v1.5.xx and after. Signed-off-by: Yves Vandervennet <yves.vandervennet@nxp.com>
butok
reviewed
Apr 26, 2024
| _cmd_core = "" | ||
|
|
||
| linkserver_cmd = ([self.linkserver, "flash"] + ["--probe", str(self.probe)] + self.override_cli + [self.device+_cmd_core]) | ||
| linkserver_cmd = ([self.linkserver, "flash"] + ["--probe", str(self.probe)] + self.override_cli + [self.device]) |
Contributor
There was a problem hiding this comment.
Could it be conditional? Something like self.linkserver_version_str >= "v1.5.30"
So the runner can work for all LinkServer versions.
Contributor
Author
There was a problem hiding this comment.
No, because the newer version just enforces the core be not specified. In the past, LinkServer ignored it. With the current code, older versions will work as well.
Contributor
|
I can confirm that this works for me, so for what it's worth, you can add Tested-by: Detlev Zundel dzu@member.fsf.org |
danieldegrasse
approved these changes
Apr 29, 2024
Contributor
|
Tested this with Linkserver 1.4.85, as well as 1.5.30. Both versions function correctly. |
dleach02
approved these changes
Apr 30, 2024
dleach02
added
the
Trivial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinkServer v1.5.30 brings changes to the flash command: there is no need to specify the core. This is actually rejected with linkserver v1.5.xx and after.
This commit brings changes to the west runner for LinkServer to reflect this CLI change.