Skip to content

drivers: sensor: si7006: fix redundant include in si7006#73420

Merged
henrikbrixandersen merged 1 commit intozephyrproject-rtos:mainfrom
margheritamilani:fix-include-si7006
May 29, 2024
Merged

drivers: sensor: si7006: fix redundant include in si7006#73420
henrikbrixandersen merged 1 commit intozephyrproject-rtos:mainfrom
margheritamilani:fix-include-si7006

Conversation

@margheritamilani
Copy link
Copy Markdown
Contributor

Remove redundant include of zephyr/logging/log.h in si7006.c.

@zephyrbot zephyrbot added area: Sensors Sensors Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. labels May 28, 2024
@bjarki-andreasen
Copy link
Copy Markdown
Contributor

Usually the logging include in right above the log module register macro:

...

#include <zephyr/logging/log.h>
LOG_MODULE_REGISTER(si7006, CONFIG_SENSOR_LOG_LEVEL);

...

could you move the remaining include down a bit :)

@bjarki-andreasen bjarki-andreasen self-requested a review May 28, 2024 15:40
Remove redundant include of `zephyr/logging/log.h` in si7006.c.

Signed-off-by: Margherita Milani <margherita.milani@amarulasolutions.com>
@henrikbrixandersen henrikbrixandersen merged commit 885d271 into zephyrproject-rtos:main May 29, 2024
@github-actions
Copy link
Copy Markdown

Hi @margheritamilani!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Sensors Sensors Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants