drivers: gpio: stm32: keep track of clock enabling per pin #78725
Conversation
|
Hello @jbr-ia, and thank you very much for your first pull request to the Zephyr project! |
zephyrbot
requested review from
GeorgeCGV,
gautierg-st,
henrikbrixandersen,
marwaiehm-st,
mathieuchopstm and
mnkp
drivers/gpio/gpio_stm32.c
Outdated
There was a problem hiding this comment.
I think this clarification would be useful.
| /* Release clock only if pin is disconnected */ | |
| /* Decrement GPIO usage count only if pin is now disconnected after being connected */ |
There was a problem hiding this comment.
I think that is indeed a better comment. The pull-request is updated.
drivers/gpio/gpio_stm32.h
Outdated
There was a problem hiding this comment.
| /* keep track of pins that have enabled the clock*/ | |
| /* keep track of pins that are connected & need GPIO clock to be enabled */ |
There was a problem hiding this comment.
Thanks, I have updated the pull-request.
The driver enables the clock of a gpio-port if any of the pins use the port. This is done by calling pm_device_runtime_get when a pin is used and pm_device_runtime_put when the pin is not used anymore. These calls needs to be balanced. But if a single pin was configured as GPIO_DISCONNECTED multiple times, every time pm_device_runtime_put was called. This caused the clock of the port to be stopped and therefore also other pins on the same port stopped working. This commit fixes this by keeping track of which pin on a port has requested the clock and only call pm_device_runtime_get or pm_device_runtime_put when the clock-request for the specific pin changes. Fixes zephyrproject-rtos#77698 Signed-off-by: Jeroen Broersen <jbroersen@interact.nl>
jbr-ia
force-pushed
the
gpio_allow_multiple_disconnect
branch
from
40e788f to
2a4f467
Compare
|
Hi @jbr-ia! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
7 participants
The driver enables the clock of a gpio-port if any of the pins use the port. This is done by calling pm_device_runtime_get when a pin is used and pm_device_runtime_put when the pin is not used anymore.
These calls needs to be balanced. But if a single pin was configured as GPIO_DISCONNECTED multiple times, every time pm_device_runtime_put was called.
This caused the clock of the port to be stopped and therefore also other pins on the same port stopped working.
This commit fixes this by keeping track of which pin on a port has requested the clock and only call pm_device_runtime_get or pm_device_runtime_put when the clock-request for the specific pin changes.
Fixes #77698