drivers: clock_control: nrf54h: obtain oscillator parameters from BICR #81122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarull
force-pushed
the
bicr-rework
branch
2 times, most recently
from
c4525dc to
dded562
Compare
anangl
reviewed
Nov 8, 2024
anangl
reviewed
Nov 8, 2024
gmarull
force-pushed
the
bicr-rework
branch
2 times, most recently
from
9654417 to
b92de2c
Compare
zephyrbot
requested review from
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
hubertmis
reviewed
Nov 8, 2024
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nordic
DNM
zephyrbot
removed
manifest
manifest-hal_nordic
DNM
Member
Author
|
DNM: will likely require reflashing BICR as some parameters were never written there. |
bjarki-andreasen
previously approved these changes
Nov 25, 2024
Contributor
bjarki-andreasen
left a comment
bjarki-andreasen
left a comment
There was a problem hiding this comment.
It pains me to see properties related to specific peripheral instances not be part of the peripherals descriptions themselves, but that is actually how this platform works...
masz-nordic
reviewed
Nov 27, 2024
hubertmis
reviewed
Nov 28, 2024
Member
There was a problem hiding this comment.
I would suggest to add a prefix to this function, considering it's available in the global scope
Add binding for the Nordic nRF BICR memory. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
BICR (Board Information Configuration Registers) are located within the application UICR region (ref. MRAM mapping, table 38). Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
The real, applicable and trusted values are the ones flashed into BICR. So, drop DT properties that replicate BICR and use runtime reads to BICR instead. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Add a utility function to obtain LFOSC accuracy in PPM from BICR. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
The real, applicable and trusted values are the ones flashed into BICR. So, drop DT properties that replicate BICR and use runtime reads to BICR instead. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
The real, applicable and trusted values are the ones flashed into BICR. So, drop DT properties that replicate BICR and use runtime reads to BICR instead. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
bjarki-andreasen
approved these changes
Dec 17, 2024
carlescufi
approved these changes
Dec 18, 2024
masz-nordic
approved these changes
Dec 18, 2024
| (idx * sizeof(array[0])) - \ | ||
| offsetof(type, array[0])) | ||
|
|
||
| #define BICR (NRF_BICR_Type *)DT_REG_ADDR(DT_NODELABEL(bicr)) |
Contributor
There was a problem hiding this comment.
NRF_BICR could be used here an in other files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BICR should be taken as the source of truth for certain oscillator-related parameters, such as:
Currently, these were replicated in Devicetree, making it possible to have a non-fully functional system due to mismatches.