STM32N6 : Add the support of the USB and UDC#84976
Merged
kartben merged 8 commits intoApr 14, 2025
Merged
Conversation
zephyrbot
added
area: UART
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
PerMac,
carlescufi,
dcpleung,
djiatsaf-st,
erwango,
gautierg-st,
golowanow,
hakehuang,
mathieuchopstm,
mbolivar,
nashif,
pdgendt and
swinslow
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_stm32
DNM
marwaiehm-st
force-pushed
the
upstream_usb_stm32n6_f
branch
2 times, most recently
from
8b0f1ac to
762ff4f
Compare
mbolivar
reviewed
Jan 31, 2025
mbolivar
left a comment
mbolivar
left a comment
Contributor
There was a problem hiding this comment.
Runner changes look reasonable to me, no objections. Found a couple of nonblocking minor things
marwaiehm-st
force-pushed
the
upstream_usb_stm32n6_f
branch
from
762ff4f to
71f6ed0
Compare
kartben
previously approved these changes
Apr 9, 2025
erwango
previously approved these changes
Apr 9, 2025
marwaiehm-st
changed the title
Add STM32N6 USB OTG HS compatible 'st,stm32n6-otghs' that doesn't require pinctrl-0 and pinctrl-names. Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
Add the USB OTG HS node for the STM32N6X devices Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
jfischer-no
previously approved these changes
Apr 9, 2025
Enable the USB OTG HS node of the nucleo_n657x0_q board Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
Enable the USB OTG HS node of the stm32n6570_dk board Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
Enable clock and power for the OTG HS peripheral of the STM32N6x serie Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
Add the usbd test feature to twister.yaml for the boards nucleo_n657x0_q and stm32n6570_dk. Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
Add STM32N6 family support to UDC driver Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
marwaiehm-st
dismissed stale reviews from jfischer-no, erwango, and kartben
via
a03c9b2
marwaiehm-st
force-pushed
the
upstream_usb_stm32n6_f
branch
from
734375a to
a03c9b2
Compare
JarmouniA
reviewed
Apr 9, 2025
Contributor
There was a problem hiding this comment.
I know this is coming late, but why not leave this as is, and use property-blocklist in st,stm32n6-otghs.yaml to filter out pinctrl-0 & pinctrl-names? (similar to
Contributor
There was a problem hiding this comment.
This is Zephyr specific, right? @mbolivar How will property-blocklist/allowlist be handled in the future?
Contributor
There was a problem hiding this comment.
This is Zephyr specific, right?
Yes, I think so.
jfischer-no
previously approved these changes
Apr 9, 2025
Contributor
Author
|
I added the label DNM because we should wait for the PR #86100 to be merged first |
- Unified the handling of USB OTG HS and USB OTG FS by removing redundant preprocessor conditionals. - Introduced a new macro `UDC_STM32_BASE_ADDRESS` to dynamically set the USB base address. Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
marwaiehm-st
force-pushed
the
upstream_usb_stm32n6_f
branch
from
232228e to
5c1bbb7
Compare
Contributor
Author
|
I added a commit to read the correct USB OTG configurations (instance), so there is no need to wait for this PR #86100 to be merged anymore. |
erwango
approved these changes
Apr 14, 2025
kartben
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the support of the USB OTG HS
Enable the USB OTG HS node of the stm32n6570_dk and nucleo_n657x0_q boards.