Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: add basic support for reel board #9451

Merged
merged 6 commits into from Aug 17, 2018

Conversation

jfischer-no
Copy link
Collaborator

Add basic support for the reel board

jfischer-no added 2 commits Aug 15, 2018
Do not use hardcoded I2C address.

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
Add dt bindings for HDC1008 sensor.

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
@codecov-io
Copy link

codecov-io commented Aug 15, 2018

Codecov Report

No coverage uploaded for pull request base (master@94acc18). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9451   +/-   ##
=========================================
  Coverage          ?   52.27%           
=========================================
  Files             ?      212           
  Lines             ?    25921           
  Branches          ?     5570           
=========================================
  Hits              ?    13549           
  Misses            ?    10115           
  Partials          ?     2257

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94acc18...b8eb442. Read the comment docs.

@jhedberg
Copy link
Member

Isn't "board" implied in pretty much all the used contexts (e.g. BOARD=... or boards/..., i.e. wouldn't just "reel" be nicer/shorter than "reel_board" for the board name? Or there's some other idea why this board should have _board appended to its name?

flash: 1024
toolchain:
- zephyr
- gccarmemb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gnuarmemb

Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things

#
---
title: APDS9960 Digital Proximity, Ambient Light, RGB and Gesture Sensor
id: broadcom,apds9960
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like linux uses avago,apds9960

flash: 1024
toolchain:
- zephyr
- gccarmemb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gnuarmemb

#define SW0_GPIO_PIN_PUD GPIO_PUD_PULL_UP

/* Onboard GREEN LED D13 */
#define LED0_GPIO_PIN 13
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move these into dts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jfischer-no jfischer-no force-pushed the pr/reel_board branch 2 times, most recently from c9fc18f to d586186 Compare Aug 16, 2018
@nashif
Copy link
Member

nashif commented Aug 16, 2018

fyi: got the board now and was able to test this PR with the board, looks nice.

@jfischer-no
Copy link
Collaborator Author

Isn't "board" implied in pretty much all the used contexts (e.g. BOARD=... or boards/..., i.e. wouldn't just "reel" be nicer/shorter than "reel_board" for the board name?

Yes, probably.

Or there's some other idea why this board should have _board appended to its name?

I assumed that one would look for "reel board" or expects "reel_board" because of the name "reel board" on the front.

Overview
********

reel board is a evaluation board based on the Nordic Semiconductor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to find some mention of the reel board on the Phytec site (for additional hardware information) but no mention of it was found.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be the documentation for the board, I will extend it step by step. Schematic will be published latest by the end of October.

@@ -0,0 +1,409 @@
.. _reel_board:

reel board
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally don't include "board" in the doc title (check out http://docs.zephyrproject.org/boards/boards.html )

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change it if desired, see my comment above #9451 (comment)


reel board is a evaluation board based on the Nordic Semiconductor
nRF52840 SoC. The board was developed by PHYTEC Messtechnik GmbH in
cooperation with Zephyr |trade| Project for the Hackathon - "Get Connected".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave off the trademark symbol here.

How does a developer get one of these boards (only from attending a hackathon)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boards will also be available after the event, how and where will be added, at the latest before the hackathon.

reel board is a evaluation board based on the Nordic Semiconductor
nRF52840 SoC. The board was developed by PHYTEC Messtechnik GmbH in
cooperation with Zephyr |trade| Project for the Hackathon - "Get Connected".
The board has also a built-in debug adapter based on the DAPLink interface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete also

firmware and NXP MK20DX128VFM5 SoC.

reel board is more than just another evaluation board.
It is equipped with the Electrophoretic Display and environmental sensors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity and grammar, change this to:

The reel board is equipped with an Electrophoretic (electronic ink) Display,
environmental (temperature, humidity, light, accelerometer) sensors, and
Bluetooth connectivity making it easy to experiment and evaluate the
Zephyr OS in these kinds of use cases:

* battery-powered sensor node
* low-power, low-cost human-machine interface (HMI) for remote
  control and environmental sensor monitoring
* temperature and humidity monitor on your table
* product, name, or price tag
* interactive badge for meetings and conferences

The mode is controlled by MODE pin (P1.00).

.. note::
Actually there is no possibility to reduce energy consumption by the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing. The previous bullet points said peripheral power is off in low-power mode?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it can not be used by the software and is not yet implemented.

| P1.15 | edge connector pin 4 | None |
+-------+-----------------------+---------------------------+

Edge Connector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What part number would I purchase (and from whom) to get an edge connector?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctly it is only the footprint for a connector, one can solder (standard, through hole) 2.54mm pin header (X2X22 2.54) to the edge connector footprint. I will expand it later and insert a example.


Debug Adapter is based on the DAPLink interface firmware and
NXP MK20DX128VFM5 SoC. The adapter is powered via micro USB connector and
is always on when the board is connected to the USB host.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this imply that the debug adapter is NOT functional if the board is powered using the on-board battery?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, "can be flashed and debugged, powered either from battery or USB"

There are 2 samples that allow you to test that the buttons (switches) and
LEDs on the board are working properly with Zephyr:

.. code-block:: console
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this code block into a bullet list:

* :ref:`blinky-sample`
* :ref:`button-sample`


.. _DAPLink reel board Firmware:
https://github.com/jfischer-phytec-iot/DAPLink/tree/reel-board

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the blank lines at the end of the file

@jfischer-no
Copy link
Collaborator Author

@nashif the branch with display support is still here https://github.com/jfischer-phytec-iot/zephyr/tree/WIP/fischer/reel_board (rebased on this PR)

jfischer-no added 4 commits Aug 16, 2018
Whitelist arduino_101_sss.

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
Add dt bindings.

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
Add basic support for the reel board

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
Whitelist reel board.

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
@nashif
Copy link
Member

nashif commented Aug 17, 2018

@nashif the branch with display support is still here jfischer-phytec-iot/zephyr:fischer/reel_board@WIP (rebased on this PR)

yes, tried that and it works. thanks.

@nashif
Copy link
Member

nashif commented Aug 17, 2018

so we are keeping it as "reel Board"?

nashif
nashif approved these changes Aug 17, 2018
galak
galak approved these changes Aug 17, 2018
@nashif nashif merged commit c9c8bbf into zephyrproject-rtos:master Aug 17, 2018
@jfischer-no jfischer-no deleted the pr/reel_board branch Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants