New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: add basic support for reel board #9451

Merged
merged 6 commits into from Aug 17, 2018

Conversation

Projects
None yet
6 participants
@jfischer-phytec-iot
Collaborator

jfischer-phytec-iot commented Aug 15, 2018

Add basic support for the reel board

jfischer-phytec-iot added some commits Jul 25, 2018

drivers: hdc1008: do not use hardcoded I2C address
Do not use hardcoded I2C address.

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
drivers: hdc1008: add dt bindings
Add dt bindings for HDC1008 sensor.

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 15, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@94acc18). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9451   +/-   ##
=========================================
  Coverage          ?   52.27%           
=========================================
  Files             ?      212           
  Lines             ?    25921           
  Branches          ?     5570           
=========================================
  Hits              ?    13549           
  Misses            ?    10115           
  Partials          ?     2257

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94acc18...b8eb442. Read the comment docs.

codecov-io commented Aug 15, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@94acc18). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9451   +/-   ##
=========================================
  Coverage          ?   52.27%           
=========================================
  Files             ?      212           
  Lines             ?    25921           
  Branches          ?     5570           
=========================================
  Hits              ?    13549           
  Misses            ?    10115           
  Partials          ?     2257

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94acc18...b8eb442. Read the comment docs.

@jhedberg

This comment has been minimized.

Show comment
Hide comment
@jhedberg

jhedberg Aug 15, 2018

Member

Isn't "board" implied in pretty much all the used contexts (e.g. BOARD=... or boards/..., i.e. wouldn't just "reel" be nicer/shorter than "reel_board" for the board name? Or there's some other idea why this board should have _board appended to its name?

Member

jhedberg commented Aug 15, 2018

Isn't "board" implied in pretty much all the used contexts (e.g. BOARD=... or boards/..., i.e. wouldn't just "reel" be nicer/shorter than "reel_board" for the board name? Or there's some other idea why this board should have _board appended to its name?

@galak

Some minor things

Show outdated Hide outdated dts/bindings/sensor/broadcom,apds9960.yaml
Show outdated Hide outdated boards/arm/reel_board/reel_board.yaml
Show outdated Hide outdated boards/arm/reel_board/board.h
@nashif

This comment has been minimized.

Show comment
Hide comment
@nashif

nashif Aug 16, 2018

Member

fyi: got the board now and was able to test this PR with the board, looks nice.

Member

nashif commented Aug 16, 2018

fyi: got the board now and was able to test this PR with the board, looks nice.

@jfischer-phytec-iot

This comment has been minimized.

Show comment
Hide comment
@jfischer-phytec-iot

jfischer-phytec-iot Aug 16, 2018

Collaborator

Isn't "board" implied in pretty much all the used contexts (e.g. BOARD=... or boards/..., i.e. wouldn't just "reel" be nicer/shorter than "reel_board" for the board name?

Yes, probably.

Or there's some other idea why this board should have _board appended to its name?

I assumed that one would look for "reel board" or expects "reel_board" because of the name "reel board" on the front.

Collaborator

jfischer-phytec-iot commented Aug 16, 2018

Isn't "board" implied in pretty much all the used contexts (e.g. BOARD=... or boards/..., i.e. wouldn't just "reel" be nicer/shorter than "reel_board" for the board name?

Yes, probably.

Or there's some other idea why this board should have _board appended to its name?

I assumed that one would look for "reel board" or expects "reel_board" because of the name "reel board" on the front.

Overview
********
reel board is a evaluation board based on the Nordic Semiconductor

This comment has been minimized.

@dbkinder

dbkinder Aug 16, 2018

Collaborator

I was hoping to find some mention of the reel board on the Phytec site (for additional hardware information) but no mention of it was found.

@dbkinder

dbkinder Aug 16, 2018

Collaborator

I was hoping to find some mention of the reel board on the Phytec site (for additional hardware information) but no mention of it was found.

This comment has been minimized.

@jfischer-phytec-iot

jfischer-phytec-iot Aug 16, 2018

Collaborator

This will be the documentation for the board, I will extend it step by step. Schematic will be published latest by the end of October.

@jfischer-phytec-iot

jfischer-phytec-iot Aug 16, 2018

Collaborator

This will be the documentation for the board, I will extend it step by step. Schematic will be published latest by the end of October.

@@ -0,0 +1,409 @@
.. _reel_board:
reel board

This comment has been minimized.

@dbkinder

dbkinder Aug 16, 2018

Collaborator

We generally don't include "board" in the doc title (check out http://docs.zephyrproject.org/boards/boards.html )

@dbkinder

dbkinder Aug 16, 2018

Collaborator

We generally don't include "board" in the doc title (check out http://docs.zephyrproject.org/boards/boards.html )

This comment has been minimized.

@jfischer-phytec-iot

jfischer-phytec-iot Aug 16, 2018

Collaborator

I can change it if desired, see my comment above #9451 (comment)

@jfischer-phytec-iot

jfischer-phytec-iot Aug 16, 2018

Collaborator

I can change it if desired, see my comment above #9451 (comment)

Show outdated Hide outdated boards/arm/reel_board/doc/reel_board.rst
Show outdated Hide outdated boards/arm/reel_board/doc/reel_board.rst
Show outdated Hide outdated boards/arm/reel_board/doc/reel_board.rst
The mode is controlled by MODE pin (P1.00).
.. note::
Actually there is no possibility to reduce energy consumption by the

This comment has been minimized.

@dbkinder

dbkinder Aug 16, 2018

Collaborator

This is confusing. The previous bullet points said peripheral power is off in low-power mode?

@dbkinder

dbkinder Aug 16, 2018

Collaborator

This is confusing. The previous bullet points said peripheral power is off in low-power mode?

This comment has been minimized.

@jfischer-phytec-iot

jfischer-phytec-iot Aug 16, 2018

Collaborator

Yes, but it can not be used by the software and is not yet implemented.

@jfischer-phytec-iot

jfischer-phytec-iot Aug 16, 2018

Collaborator

Yes, but it can not be used by the software and is not yet implemented.

| P1.15 | edge connector pin 4 | None |
+-------+-----------------------+---------------------------+
Edge Connector

This comment has been minimized.

@dbkinder

dbkinder Aug 16, 2018

Collaborator

What part number would I purchase (and from whom) to get an edge connector?

@dbkinder

dbkinder Aug 16, 2018

Collaborator

What part number would I purchase (and from whom) to get an edge connector?

This comment has been minimized.

@jfischer-phytec-iot

jfischer-phytec-iot Aug 16, 2018

Collaborator

Correctly it is only the footprint for a connector, one can solder (standard, through hole) 2.54mm pin header (X2X22 2.54) to the edge connector footprint. I will expand it later and insert a example.

@jfischer-phytec-iot

jfischer-phytec-iot Aug 16, 2018

Collaborator

Correctly it is only the footprint for a connector, one can solder (standard, through hole) 2.54mm pin header (X2X22 2.54) to the edge connector footprint. I will expand it later and insert a example.

Debug Adapter is based on the DAPLink interface firmware and
NXP MK20DX128VFM5 SoC. The adapter is powered via micro USB connector and
is always on when the board is connected to the USB host.

This comment has been minimized.

@dbkinder

dbkinder Aug 16, 2018

Collaborator

Does this imply that the debug adapter is NOT functional if the board is powered using the on-board battery?

@dbkinder

dbkinder Aug 16, 2018

Collaborator

Does this imply that the debug adapter is NOT functional if the board is powered using the on-board battery?

This comment has been minimized.

@jfischer-phytec-iot

jfischer-phytec-iot Aug 16, 2018

Collaborator

No, "can be flashed and debugged, powered either from battery or USB"

@jfischer-phytec-iot

jfischer-phytec-iot Aug 16, 2018

Collaborator

No, "can be flashed and debugged, powered either from battery or USB"

Show outdated Hide outdated boards/arm/reel_board/doc/reel_board.rst
Show outdated Hide outdated boards/arm/reel_board/doc/reel_board.rst
@jfischer-phytec-iot

This comment has been minimized.

Show comment
Hide comment
@jfischer-phytec-iot

jfischer-phytec-iot Aug 16, 2018

Collaborator

@nashif the branch with display support is still here https://github.com/jfischer-phytec-iot/zephyr/tree/WIP/fischer/reel_board (rebased on this PR)

Collaborator

jfischer-phytec-iot commented Aug 16, 2018

@nashif the branch with display support is still here https://github.com/jfischer-phytec-iot/zephyr/tree/WIP/fischer/reel_board (rebased on this PR)

jfischer-phytec-iot added some commits Aug 16, 2018

samples: apds9960: whitelist arduino_101_sss
Whitelist arduino_101_sss.

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
boards: add basis support for the reel board
Add basic support for the reel board

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
drivers: apds9960: add dt bindings
Add dt bindings.

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
samples: apds9960: whitelist reel board
Whitelist reel board.

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
@nashif

This comment has been minimized.

Show comment
Hide comment
@nashif

nashif Aug 17, 2018

Member

@nashif the branch with display support is still here jfischer-phytec-iot/zephyr:fischer/reel_board@WIP (rebased on this PR)

yes, tried that and it works. thanks.

Member

nashif commented Aug 17, 2018

@nashif the branch with display support is still here jfischer-phytec-iot/zephyr:fischer/reel_board@WIP (rebased on this PR)

yes, tried that and it works. thanks.

@nashif

This comment has been minimized.

Show comment
Hide comment
@nashif

nashif Aug 17, 2018

Member

so we are keeping it as "reel Board"?

Member

nashif commented Aug 17, 2018

so we are keeping it as "reel Board"?

@nashif

nashif approved these changes Aug 17, 2018

@galak

galak approved these changes Aug 17, 2018

@nashif nashif merged commit c9c8bbf into zephyrproject-rtos:master Aug 17, 2018

1 check passed

Shippable Run 20835 status is SUCCESS.
Details

@jfischer-phytec-iot jfischer-phytec-iot deleted the jfischer-phytec-iot:pr/reel_board branch Aug 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment