Mcxe247 enable lmem cache #98384
Mcxe247 enable lmem cache #98384
Conversation
zephyrbot
added
area: Cache
platform: NXP
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
JiafeiPan,
MaochenWang1,
PetervdPerk-NXP,
ZhaoxiangJin,
axelnxp,
bperseghetti,
butok,
dbaluta,
decsny,
dleach02,
manuargue,
mmahadevan108 and
nashif
Holt-Sun
force-pushed
the
mcxe247-enable-lmem-cache
branch
2 times, most recently
from
54eba40 to
6425b6f
Compare
drivers/cache/cache_nxp_lmem_cache.c
Outdated
|
|
||
| int cache_instr_invd_range(void *addr, size_t size) | ||
| { | ||
| L1CACHE_InvalidateCodeCacheByRange((uint32_t)addr, size); |
There was a problem hiding this comment.
nit: you might want to also caste size to uint32_t since the underlying API defines it this way. Although I'm aware it is unlikely we would be building this for a 64bit platform.
There was a problem hiding this comment.
Add uint32_t for size.
drivers/cache/cache_nxp_lmem_cache.c
Outdated
| #include <zephyr/logging/log.h> | ||
| #include <fsl_cache.h> | ||
|
|
||
| LOG_MODULE_REGISTER(cache_nxp_lmem_cache, CONFIG_CACHE_LOG_LEVEL); |
There was a problem hiding this comment.
can removed since log is not used?
Holt-Sun
force-pushed
the
mcxe247-enable-lmem-cache
branch
from
6425b6f to
e48c53a
Compare
| default y | ||
|
|
||
| # Enable cache management features | ||
| config CACHE_MANAGEMENT |
There was a problem hiding this comment.
There is an initiative to use "configdefault" in this case: 5805685
There was a problem hiding this comment.
Updated to configdefault.
Holt-Sun
force-pushed
the
mcxe247-enable-lmem-cache
branch
from
e48c53a to
0378cf0
Compare
Holt-Sun
force-pushed
the
mcxe247-enable-lmem-cache
branch
from
0378cf0 to
c84c218
Compare
|
@Holt-Sun lets address the compliance issues, merge conflicts, and twister errors. |
…E24X Select cache_lmem component for MCXE24X devices. This exposes the LMEM cache API needed by the Zephyr driver Signed-off-by: Holt Sun <holt.sun@nxp.com>
Add LMEM cache driver implementing instruction cache ops. Wire driver into cache Kconfig menu and CMake build. Enables I-cache control on SoCs with NXP LMEM controller. Signed-off-by: Holt Sun <holt.sun@nxp.com>
Select CPU_HAS_ICACHE and HAS_MCUX_LMEM_CACHE. Default CACHE_MANAGEMENT=y and select EXTERNAL_CACHE. Prepares MCXE24x to use the LMEM cache driver. Signed-off-by: Holt Sun <holt.sun@nxp.com>
Holt-Sun
force-pushed
the
mcxe247-enable-lmem-cache
branch
from
c84c218 to
a8b7c54
Compare
|
|
Hi @nashif , do you see anything that block the merge of this PR? Thank you. |
PR needs get approval from assignee before merge. |
Thank you for the information. |
8 participants
Enable LMEM cache for MCXE247.