Update zc143ac72mipi co5300 driver and display driver example #98778

KATE-WANG-NXP · 2025-11-03T12:12:43Z

Add user configuration of buffer address alignment and update area pitch's alignment for display driver sample.
Add board specific configuration for mimxrt700_evk lvgl examples. The mimxrt700_evk uses DC8000 to drive all panels which requires a 64-byte align of buffer address and stride.
Update CO5300 panel driver
3.1 Fix wrong backlight pin in driver overlay
3.2 Remove the power-on pin configuration in code and binding, and add mipi display panel regulator in panel overlay instead. Set 'regulator-boot-on' to true means the power-on pin will be enabled during system boot.
3.3 Remove 'last_known_framebuffer' from panel data structure. It is not used anywhere
3.4 Fix bug in 'co5300_set_pixel_format' function.
3.5 Fix the issue that the panel does not support start coordinates and the width/height of the updated area being odd value.
Solution: In panel driver, maintain a full screen-sized buffer, its address and pitch alignment is configurable in device tree and shall be compliant with the display controller's requirements. It can be placed in RAM or if the RAM space is not enough it can also be placed in other memory resion. When there is a frame update request, the updated area will be first filled to the buffer, if the area's size or coordinate is odd, adjust the value so the real updated area covers the requested updated area, then use this buffer to send pixel to panel, this can ensure the updated area's size and coordinate are always even.

EmilioCBen · 2025-11-03T15:45:00Z

drivers/display/display_co5300.c

+	 * area is row 6~472 and line 0~466. So adjust coordinates accordingly.
+	 */
 	/* First two bytes are starting X coordinate */
-	start_xpos = x;


Should we update the width and height of the panel in the shield overlay instead of adding this runtime calculations?

Hi, it is not the height and width, it is that to the co5300 controller the panel is 472x466 while actually the first 6 rows are cut off physically to make it a round panel, so if the higher app wants to update from 0,0, we need to pass 6,0 to the co5300 controller

Is it zc143ac72 panel specific? If this controller is used by other panels, could this value be different?

@zejiang0jason Yes the driver display_co5300 is used by zc143ac72 only

samples/drivers/display/src/main.c

samples/modules/lvgl/demos/boards/mimxrt700_evk_mimxrt798s_cm33_cpu0.conf

boards/shields/zc143ac72mipi/zc143ac72mipi.overlay

uLipe

I just have a question.

drivers/display/display_co5300.c

faxe1008 · 2025-11-19T16:03:44Z

drivers/display/display_co5300.c

 		data->bytes_per_pixel = 2;
 		break;
 	case PIXEL_FORMAT_RGB_888:
 		data->pixel_format = MIPI_DSI_PIXFMT_RGB888;


Hmm usually the pixel format is set to the data only after the command succeeded otherwise you get inconsistent state.

zejiang0jason · 2025-11-20T06:58:34Z

samples/drivers/display/src/main.c

 	}

+	rect_w = ROUND_UP(rect_w, CONFIG_SAMPLE_PITCH_ALIGN);
+


suggest change:

size_t rect_pitch = ROUND_UP(rect_w, CONFIG_SAMPLE_PITCH_ALIGN); size_t full_screen_pitch = ROUND_UP(capabilities.x_resolution, CONFIG_SAMPLE_PITCH_ALIGN); buf_size = MAX(rect_pitch * rect_h, full_screen_pitch * h_step);

The variables rect_pitch and full_screen_pitch can be used later in buf_desc setting.

zejiang0jason · 2025-11-20T07:15:05Z

drivers/display/display_co5300.c

+	local_desc.width = ROUND_UP(local_desc.width, 2U);
+	local_desc.height = ROUND_UP(local_desc.height, 2U);
+	local_desc.width = desc->width + 1;
+	local_desc.height = desc->height + 1;


why assign the local_desc.width and local_desc.height again?

sorry, typo

zejiang0jason · 2025-11-20T07:19:31Z

drivers/display/display_co5300.c

+	 * area is row 6~472 and line 0~466. So adjust coordinates accordingly.
+	 */
 	/* First two bytes are starting X coordinate */
-	start_xpos = x;


Is it zc143ac72 panel specific? If this controller is used by other panels, could this value be different?

zejiang0jason · 2025-11-20T07:24:00Z

drivers/display/display_co5300.c

+	local_desc.width = desc->width + 1;
+	local_desc.height = desc->height + 1;
+	local_desc.pitch = data->frame_pitch;
+	local_desc.frame_incomplete = desc->frame_incomplete;


can we only send out whole dirty region, when the frame_incomplete is false?

Yes that is what we do now in every update, the frame_incomplete param in the descriptor passed down from app level is needed and used by some of low level driver like lcdic or dbi_spi, we just preserve and pass down the param, it is not actually used.

zejiang0jason · 2025-11-20T07:31:50Z

drivers/display/display_co5300.c

+	while (tx_size > 0) {
+		msg.tx_len = tx_size;
+		msg.tx_buf = src;
 		bytes_written = (int)mipi_dsi_transfer(config->mipi_dsi, config->channel, &msg);


the tx_size is the whole data size, is the data to be sent continuous in memory? if not, can mipi_dsi_transfer support non-continuous data?

yes, it can if using lcdif

zejiang0jason · 2025-11-20T07:38:09Z

drivers/display/display_co5300.c

+	local_desc.height = desc->height + 1;
+	local_desc.pitch = data->frame_pitch;
+	local_desc.frame_incomplete = desc->frame_incomplete;
+	local_desc.buf_size = local_desc.width * local_desc.height * data->bytes_per_pixel;


if possible, suggest make this area adjustment as a static function, currently this function is very large.

drivers/display/display_rm67162.c

drivers/mipi_dbi/mipi_dbi_nxp_dcnano_lcdif.c

drivers/display/display_co5300.c

Add user configuration of buffer address alignment and update area pitch alignment. Signed-off-by: Kate Wang <yumeng.wang@nxp.com>

The mimxrt700_evk uses DC8000 to drive panel which requires a 64 byte align of buffer address and stride. Signed-off-by: Kate Wang <yumeng.wang@nxp.com>

boards/shields/zc143ac72mipi/boards/mimxrt700_evk_mimxrt798s_cm33_cpu0.overlay

drivers/display/display_co5300.c

dts/bindings/display/chipone,co5300.yaml

drivers/display/display_co5300.c

dts/bindings/display/chipone,co5300.yaml

1. Fix wrong backlight pin in driver overlay 2. Remove the power-on pin configuration in code and binding, and add mipi display panel regulator in panel overlay instead. Set regulator-boot-on' to true means the power-on pin will be enabled uring system boot. 3. Remove 'last_known_framebuffer' from panel data structure. It is not used anywhere 4. Fix bug in 'co5300_set_pixel_format' function. 5. Fix the issue that the panel does not support start coordinates and the width/height of the updated area being odd value. Solution: In panel driver, maintain a full screen-sized buffer, its address and pitch alignment is configurable in device tree and shall be compliant with the display controller's requirements. It can be placed in RAM or if the RAM space is not enough it can also be placed in other memory resion. When there is a frame update request, the updated area will be first filled to the buffer, if the area's size or coordinate is odd, adjust the value so the real updated area covers the requested updated area, then use this buffer to send pixel to panel, this can ensure the updated area's size and coordinate are always even. Signed-off-by: Kate Wang <yumeng.wang@nxp.com>

The zc143ac72mipi panel can only accept update area that has even size and coordinates, so the panel driver was updated to maintain a buffer to collect all dirty areas. This buffer shall have address and pitch alignments which compliant to the board's display driver's requirement, and can be placed outside of ram. Update the board specific overlay to add such configurations. Signed-off-by: Kate Wang <yumeng.wang@nxp.com>

sonarqubecloud · 2025-11-28T06:49:02Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

KATE-WANG-NXP changed the title ~~Update zc143ac72mipi co5300 display example~~ Update zc143ac72mipi co5300 driver and display driver example Nov 3, 2025

zephyrbot added area: Boards/SoCs area: Samples Samples area: Devicetree Bindings area: LVGL Light and Versatile Graphics Library Support platform: NXP NXP area: Display Controller area: Shields Shields (add-on boards) area: Display labels Nov 3, 2025

zephyrbot requested review from JarmouniA, VynDragon, avisconti, danieldegrasse, dbaluta, decsny, dleach02, erwango, faxe1008, jfischer-no, kartben, manuargue, mmahadevan108, pdgendt and uLipe November 3, 2025 12:14

zephyrbot assigned kartben Nov 3, 2025

EmilioCBen reviewed Nov 3, 2025

View reviewed changes

mmahadevan108 reviewed Nov 3, 2025

View reviewed changes

samples/drivers/display/src/main.c Show resolved Hide resolved

mmahadevan108 reviewed Nov 3, 2025

View reviewed changes

samples/modules/lvgl/demos/boards/mimxrt700_evk_mimxrt798s_cm33_cpu0.conf Show resolved Hide resolved

mmahadevan108 reviewed Nov 3, 2025

View reviewed changes

boards/shields/zc143ac72mipi/zc143ac72mipi.overlay Outdated Show resolved Hide resolved

uLipe reviewed Nov 4, 2025

View reviewed changes

drivers/display/display_co5300.c Show resolved Hide resolved

faxe1008 reviewed Nov 19, 2025

View reviewed changes

kartben assigned mmahadevan108 and dleach02 and unassigned kartben Nov 19, 2025

zejiang0jason reviewed Nov 20, 2025

View reviewed changes

JarmouniA requested changes Nov 20, 2025

View reviewed changes

drivers/display/display_rm67162.c Show resolved Hide resolved

drivers/mipi_dbi/mipi_dbi_nxp_dcnano_lcdif.c Show resolved Hide resolved

drivers/display/display_co5300.c Outdated Show resolved Hide resolved

KATE-WANG-NXP requested a review from JarmouniA November 21, 2025 03:07

KATE-WANG-NXP force-pushed the update-zc143ac72mipi-co5300-display-example branch from acb7e91 to 7b04e9a Compare November 24, 2025 03:46

zephyrbot requested a review from faxe1008 November 24, 2025 03:48

KATE-WANG-NXP added 2 commits November 24, 2025 11:54

samples: drivers: display: Add user configuration

437c284

Add user configuration of buffer address alignment and update area pitch alignment. Signed-off-by: Kate Wang <yumeng.wang@nxp.com>

samples: lvgl: Add board specific configuration for mimxrt700_evk

57d6b9e

The mimxrt700_evk uses DC8000 to drive panel which requires a 64 byte align of buffer address and stride. Signed-off-by: Kate Wang <yumeng.wang@nxp.com>

KATE-WANG-NXP force-pushed the update-zc143ac72mipi-co5300-display-example branch 2 times, most recently from 97e0e5c to 9858111 Compare November 24, 2025 05:00

JarmouniA reviewed Nov 24, 2025

View reviewed changes

boards/shields/zc143ac72mipi/boards/mimxrt700_evk_mimxrt798s_cm33_cpu0.overlay Show resolved Hide resolved

KATE-WANG-NXP force-pushed the update-zc143ac72mipi-co5300-display-example branch from 9858111 to 4daf132 Compare November 27, 2025 06:22

KATE-WANG-NXP requested review from EmilioCBen, JarmouniA, uLipe and zejiang0jason November 27, 2025 06:22

JarmouniA reviewed Nov 27, 2025

View reviewed changes

dts/bindings/display/chipone,co5300.yaml Outdated Show resolved Hide resolved

KATE-WANG-NXP force-pushed the update-zc143ac72mipi-co5300-display-example branch from 4daf132 to 64a23e4 Compare November 28, 2025 06:09

zephyrbot requested a review from JarmouniA November 28, 2025 06:11

KATE-WANG-NXP added 2 commits November 28, 2025 14:16

KATE-WANG-NXP force-pushed the update-zc143ac72mipi-co5300-display-example branch from 64a23e4 to 1e666df Compare November 28, 2025 06:17

JarmouniA approved these changes Nov 28, 2025

View reviewed changes

faxe1008 approved these changes Nov 28, 2025

View reviewed changes

faxe1008 linked an issue Nov 28, 2025 that may be closed by this pull request

ZC143AC72MIPI shows green horizontal lines when using running the lvgl samples. #98892

Open

1 task

Update zc143ac72mipi co5300 driver and display driver example #98778

Are you sure you want to change the base?

Update zc143ac72mipi co5300 driver and display driver example #98778

Conversation

KATE-WANG-NXP commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KATE-WANG-NXP Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

uLipe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KATE-WANG-NXP Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 28, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

KATE-WANG-NXP commented Nov 3, 2025 •

edited

Loading

KATE-WANG-NXP Nov 6, 2025 •

edited

Loading

KATE-WANG-NXP Nov 21, 2025 •

edited

Loading