Skip to content

Conversation

@tomchy
Copy link
Contributor

@tomchy tomchy commented Nov 21, 2025

Verify memory controller node while determining a running application partition.
Currently the check uses only offsets, which may give false results if there is a partition on the external memory with a matching offset range.

Fixes #99762

@zephyrbot zephyrbot added platform: nRF Nordic nRFx area: Boards/SoCs area: mcumgr area: Tests Issues related to a particular existing or missing test area: DFU Device Firmware Upgrade labels Nov 21, 2025
@tomchy tomchy marked this pull request as draft November 21, 2025 11:03
@tomchy tomchy force-pushed the bugfix/soc/NCSIDB-1773_Handle_extmem_upstream branch from a8d7339 to 4bdcdb1 Compare November 21, 2025 11:22
@tomchy tomchy changed the title Use absolute addresses while determining a running application partition. Verify memory controller node while determining a running application partition. Nov 21, 2025
@tomchy tomchy force-pushed the bugfix/soc/NCSIDB-1773_Handle_extmem_upstream branch from 4bdcdb1 to ae65322 Compare November 21, 2025 12:00
@tomchy tomchy marked this pull request as ready for review November 21, 2025 15:13
@tomchy
Copy link
Contributor Author

tomchy commented Nov 21, 2025

Since this PR introduces a new API, it cannot be backported to v4.3 branch.
For the 4.3 branch fix, this PR should be used: #99786

@zephyrbot zephyrbot added the area: Storage Storage subsystem label Nov 21, 2025
@tomchy tomchy force-pushed the bugfix/soc/NCSIDB-1773_Handle_extmem_upstream branch from ae65322 to a355f63 Compare November 25, 2025 16:38
Copy link
Contributor

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API minor version should be incremented.

Add a macro that allows to get the node identifier of the flash
controller the area/partition resides on.

Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
Use absolute addresses while determining a running application
partition.

Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
Use absolute addresses while determining a running application
partition.

Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
Use absolute addresses while determining a running application
partition.

Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
@tomchy tomchy force-pushed the bugfix/soc/NCSIDB-1773_Handle_extmem_upstream branch from a355f63 to 7bc3f24 Compare November 26, 2025 09:05
@tomchy tomchy requested a review from JarmouniA November 26, 2025 09:05
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Boards/SoCs area: DFU Device Firmware Upgrade area: mcumgr area: Storage Storage subsystem area: Tests Issues related to a particular existing or missing test platform: nRF Nordic nRFx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mcumgr: Image management incorrectly identifies active slot when slots are on different flash devices

6 participants